mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-05 05:18:52 +08:00
ca758c36cc
This PR removes the dependency of compaction on the ID allocator by pre-allocating the logID and segmentID. issue: https://github.com/milvus-io/milvus/issues/33957 --------- Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
81 lines
2.4 KiB
Go
81 lines
2.4 KiB
Go
package datacoord
|
|
|
|
import (
|
|
"github.com/samber/lo"
|
|
"github.com/stretchr/testify/mock"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/util/merr"
|
|
)
|
|
|
|
func (s *CompactionTaskSuite) TestProcessRefreshPlan_NormalMix() {
|
|
channel := "Ch-1"
|
|
binLogs := []*datapb.FieldBinlog{getFieldBinlogIDs(101, 3)}
|
|
s.mockMeta.EXPECT().GetHealthySegment(mock.Anything).RunAndReturn(func(segID int64) *SegmentInfo {
|
|
return &SegmentInfo{SegmentInfo: &datapb.SegmentInfo{
|
|
ID: segID,
|
|
Level: datapb.SegmentLevel_L1,
|
|
InsertChannel: channel,
|
|
State: commonpb.SegmentState_Flushed,
|
|
Binlogs: binLogs,
|
|
}}
|
|
}).Times(2)
|
|
task := &mixCompactionTask{
|
|
CompactionTask: &datapb.CompactionTask{
|
|
PlanID: 1,
|
|
TriggerID: 19530,
|
|
CollectionID: 1,
|
|
PartitionID: 10,
|
|
Type: datapb.CompactionType_MixCompaction,
|
|
NodeID: 1,
|
|
State: datapb.CompactionTaskState_executing,
|
|
InputSegments: []int64{200, 201},
|
|
ResultSegments: []int64{100},
|
|
},
|
|
// plan: plan,
|
|
meta: s.mockMeta,
|
|
}
|
|
alloc := NewNMockAllocator(s.T())
|
|
alloc.EXPECT().allocN(mock.Anything).Return(100, 200, nil)
|
|
task.allocator = alloc
|
|
plan, err := task.BuildCompactionRequest()
|
|
s.Require().NoError(err)
|
|
|
|
s.Equal(2, len(plan.GetSegmentBinlogs()))
|
|
segIDs := lo.Map(plan.GetSegmentBinlogs(), func(b *datapb.CompactionSegmentBinlogs, _ int) int64 {
|
|
return b.GetSegmentID()
|
|
})
|
|
s.ElementsMatch([]int64{200, 201}, segIDs)
|
|
}
|
|
|
|
func (s *CompactionTaskSuite) TestProcessRefreshPlan_MixSegmentNotFound() {
|
|
channel := "Ch-1"
|
|
s.Run("segment_not_found", func() {
|
|
s.mockMeta.EXPECT().GetHealthySegment(mock.Anything).RunAndReturn(func(segID int64) *SegmentInfo {
|
|
return nil
|
|
}).Once()
|
|
task := &mixCompactionTask{
|
|
CompactionTask: &datapb.CompactionTask{
|
|
PlanID: 1,
|
|
TriggerID: 19530,
|
|
CollectionID: 1,
|
|
PartitionID: 10,
|
|
Channel: channel,
|
|
Type: datapb.CompactionType_MixCompaction,
|
|
State: datapb.CompactionTaskState_executing,
|
|
NodeID: 1,
|
|
InputSegments: []int64{200, 201},
|
|
ResultSegments: []int64{100},
|
|
},
|
|
meta: s.mockMeta,
|
|
}
|
|
alloc := NewNMockAllocator(s.T())
|
|
alloc.EXPECT().allocN(mock.Anything).Return(100, 200, nil)
|
|
task.allocator = alloc
|
|
_, err := task.BuildCompactionRequest()
|
|
s.Error(err)
|
|
s.ErrorIs(err, merr.ErrSegmentNotFound)
|
|
})
|
|
}
|