mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-04 21:09:06 +08:00
418 lines
14 KiB
Go
418 lines
14 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package observers
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/suite"
|
|
"go.uber.org/atomic"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/commonpb"
|
|
etcdkv "github.com/milvus-io/milvus/internal/kv/etcd"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
"github.com/milvus-io/milvus/internal/proto/querypb"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/meta"
|
|
. "github.com/milvus-io/milvus/internal/querycoordv2/params"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/session"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/utils"
|
|
"github.com/milvus-io/milvus/internal/util/etcd"
|
|
)
|
|
|
|
type LeaderObserverTestSuite struct {
|
|
suite.Suite
|
|
observer *LeaderObserver
|
|
kv *etcdkv.EtcdKV
|
|
mockCluster *session.MockCluster
|
|
|
|
meta *meta.Meta
|
|
broker *meta.MockBroker
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) SetupSuite() {
|
|
Params.Init()
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) SetupTest() {
|
|
var err error
|
|
config := GenerateEtcdConfig()
|
|
cli, err := etcd.GetEtcdClient(
|
|
config.UseEmbedEtcd.GetAsBool(),
|
|
config.EtcdUseSSL.GetAsBool(),
|
|
config.Endpoints.GetAsStrings(),
|
|
config.EtcdTLSCert.GetValue(),
|
|
config.EtcdTLSKey.GetValue(),
|
|
config.EtcdTLSCACert.GetValue(),
|
|
config.EtcdTLSMinVersion.GetValue())
|
|
suite.Require().NoError(err)
|
|
suite.kv = etcdkv.NewEtcdKV(cli, config.MetaRootPath.GetValue())
|
|
|
|
// meta
|
|
store := meta.NewMetaStore(suite.kv)
|
|
idAllocator := RandomIncrementIDAllocator()
|
|
suite.meta = meta.NewMeta(idAllocator, store, session.NewNodeManager())
|
|
suite.broker = meta.NewMockBroker(suite.T())
|
|
|
|
suite.mockCluster = session.NewMockCluster(suite.T())
|
|
distManager := meta.NewDistributionManager()
|
|
targetManager := meta.NewTargetManager(suite.broker, suite.meta)
|
|
suite.observer = NewLeaderObserver(distManager, suite.meta, targetManager, suite.broker, suite.mockCluster)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TearDownTest() {
|
|
suite.observer.Stop()
|
|
suite.kv.Close()
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestSyncLoadedSegments() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
segments := []*datapb.SegmentBinlogs{
|
|
{
|
|
SegmentID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
suite.broker.EXPECT().GetPartitions(mock.Anything, int64(1)).Return([]int64{1}, nil)
|
|
info := &datapb.SegmentInfo{
|
|
ID: 1,
|
|
CollectionID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
}
|
|
loadInfo := utils.PackSegmentLoadInfo(info, nil)
|
|
suite.broker.EXPECT().GetSegmentInfo(mock.Anything, int64(1)).Return(
|
|
&datapb.GetSegmentInfoResponse{Infos: []*datapb.SegmentInfo{info}}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfo(mock.Anything, int64(1), int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTargetWithPartitions(int64(1), int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 2, 1, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
observer.dist.LeaderViewManager.Update(2, utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{}))
|
|
expectReq := &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Set,
|
|
PartitionID: 1,
|
|
SegmentID: 1,
|
|
NodeID: 1,
|
|
Version: 1,
|
|
Info: loadInfo,
|
|
},
|
|
},
|
|
}
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(context.TODO(), int64(2), expectReq).Once().
|
|
Run(func(args mock.Arguments) { called.Store(true) }).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start(context.TODO())
|
|
|
|
suite.Eventually(
|
|
func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestIgnoreSyncLoadedSegments() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
segments := []*datapb.SegmentBinlogs{
|
|
{
|
|
SegmentID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
suite.broker.EXPECT().GetPartitions(mock.Anything, int64(1)).Return([]int64{1}, nil)
|
|
info := &datapb.SegmentInfo{
|
|
ID: 1,
|
|
CollectionID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
}
|
|
loadInfo := utils.PackSegmentLoadInfo(info, nil)
|
|
suite.broker.EXPECT().GetSegmentInfo(mock.Anything, int64(1)).Return(
|
|
&datapb.GetSegmentInfoResponse{Infos: []*datapb.SegmentInfo{info}}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfo(mock.Anything, int64(1), int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTargetWithPartitions(int64(1), int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 2, 1, "test-insert-channel"),
|
|
utils.CreateTestSegment(1, 1, 2, 2, 1, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
observer.dist.LeaderViewManager.Update(2, utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{}))
|
|
|
|
expectReq := &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Set,
|
|
PartitionID: 1,
|
|
SegmentID: 1,
|
|
NodeID: 1,
|
|
Version: 1,
|
|
Info: loadInfo,
|
|
},
|
|
},
|
|
}
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(context.TODO(), int64(2), expectReq).Once().
|
|
Run(func(args mock.Arguments) { called.Store(true) }).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start(context.TODO())
|
|
|
|
suite.Eventually(
|
|
func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestIgnoreBalancedSegment() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
segments := []*datapb.SegmentBinlogs{
|
|
{
|
|
SegmentID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
|
|
suite.broker.EXPECT().GetPartitions(mock.Anything, int64(1)).Return([]int64{1}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfo(mock.Anything, int64(1), int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTargetWithPartitions(int64(1), int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 1, 1, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
|
|
// The leader view saw the segment on new node,
|
|
// but another nodes not yet
|
|
leaderView := utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{})
|
|
leaderView.Segments[1] = &querypb.SegmentDist{
|
|
NodeID: 2,
|
|
Version: 2,
|
|
}
|
|
observer.dist.LeaderViewManager.Update(2, leaderView)
|
|
observer.Start(context.TODO())
|
|
|
|
// Nothing should happen
|
|
time.Sleep(2 * time.Second)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestSyncLoadedSegmentsWithReplicas() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 2))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(2, 1, []int64{3, 4}))
|
|
segments := []*datapb.SegmentBinlogs{
|
|
{
|
|
SegmentID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
suite.broker.EXPECT().GetPartitions(mock.Anything, int64(1)).Return([]int64{1}, nil)
|
|
info := &datapb.SegmentInfo{
|
|
ID: 1,
|
|
CollectionID: 1,
|
|
PartitionID: 1,
|
|
InsertChannel: "test-insert-channel",
|
|
}
|
|
loadInfo := utils.PackSegmentLoadInfo(info, nil)
|
|
suite.broker.EXPECT().GetSegmentInfo(mock.Anything, int64(1)).Return(
|
|
&datapb.GetSegmentInfoResponse{Infos: []*datapb.SegmentInfo{info}}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfo(mock.Anything, int64(1), int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTargetWithPartitions(int64(1), int64(1))
|
|
observer.target.UpdateCollectionCurrentTarget(1)
|
|
observer.dist.SegmentDistManager.Update(1, utils.CreateTestSegment(1, 1, 1, 1, 1, "test-insert-channel"))
|
|
observer.dist.SegmentDistManager.Update(4, utils.CreateTestSegment(1, 1, 1, 4, 2, "test-insert-channel"))
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
observer.dist.LeaderViewManager.Update(2, utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{}, map[int64]*meta.Segment{}))
|
|
observer.dist.LeaderViewManager.Update(4, utils.CreateTestLeaderView(4, 1, "test-insert-channel", map[int64]int64{1: 4}, map[int64]*meta.Segment{}))
|
|
expectReq := &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Set,
|
|
PartitionID: 1,
|
|
SegmentID: 1,
|
|
NodeID: 1,
|
|
Version: 1,
|
|
Info: loadInfo,
|
|
},
|
|
},
|
|
}
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(context.TODO(), int64(2), expectReq).Once().
|
|
Run(func(args mock.Arguments) { called.Store(true) }).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start(context.TODO())
|
|
|
|
suite.Eventually(
|
|
func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestSyncRemovedSegments() {
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
observer.dist.LeaderViewManager.Update(2, utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{3: 2}, map[int64]*meta.Segment{}))
|
|
|
|
expectReq := &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Remove,
|
|
SegmentID: 3,
|
|
NodeID: 2,
|
|
},
|
|
},
|
|
}
|
|
ch := make(chan struct{})
|
|
suite.mockCluster.EXPECT().SyncDistribution(context.TODO(), int64(2), expectReq).Once().
|
|
Run(func(args mock.Arguments) { close(ch) }).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start(context.TODO())
|
|
|
|
select {
|
|
case <-ch:
|
|
case <-time.After(2 * time.Second):
|
|
}
|
|
}
|
|
|
|
func (suite *LeaderObserverTestSuite) TestIgnoreSyncRemovedSegments() {
|
|
|
|
observer := suite.observer
|
|
observer.meta.CollectionManager.PutCollection(utils.CreateTestCollection(1, 1))
|
|
observer.meta.ReplicaManager.Put(utils.CreateTestReplica(1, 1, []int64{1, 2}))
|
|
|
|
segments := []*datapb.SegmentBinlogs{
|
|
{
|
|
SegmentID: 2,
|
|
InsertChannel: "test-insert-channel",
|
|
},
|
|
}
|
|
channels := []*datapb.VchannelInfo{
|
|
{
|
|
CollectionID: 1,
|
|
ChannelName: "test-insert-channel",
|
|
},
|
|
}
|
|
suite.broker.EXPECT().GetPartitions(mock.Anything, int64(1)).Return([]int64{1}, nil)
|
|
suite.broker.EXPECT().GetRecoveryInfo(mock.Anything, int64(1), int64(1)).Return(
|
|
channels, segments, nil)
|
|
observer.target.UpdateCollectionNextTargetWithPartitions(int64(1), int64(1))
|
|
|
|
observer.dist.ChannelDistManager.Update(2, utils.CreateTestChannel(1, 2, 1, "test-insert-channel"))
|
|
observer.dist.LeaderViewManager.Update(2, utils.CreateTestLeaderView(2, 1, "test-insert-channel", map[int64]int64{3: 2, 2: 2}, map[int64]*meta.Segment{}))
|
|
|
|
expectReq := &querypb.SyncDistributionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_SyncDistribution,
|
|
},
|
|
CollectionID: 1,
|
|
Channel: "test-insert-channel",
|
|
Actions: []*querypb.SyncAction{
|
|
{
|
|
Type: querypb.SyncType_Remove,
|
|
SegmentID: 3,
|
|
NodeID: 2,
|
|
},
|
|
},
|
|
}
|
|
called := atomic.NewBool(false)
|
|
suite.mockCluster.EXPECT().SyncDistribution(context.TODO(), int64(2), expectReq).Once().
|
|
Run(func(args mock.Arguments) { called.Store(true) }).
|
|
Return(&commonpb.Status{}, nil)
|
|
|
|
observer.Start(context.TODO())
|
|
suite.Eventually(func() bool {
|
|
return called.Load()
|
|
},
|
|
10*time.Second,
|
|
500*time.Millisecond,
|
|
)
|
|
}
|
|
|
|
func TestLeaderObserverSuite(t *testing.T) {
|
|
suite.Run(t, new(LeaderObserverTestSuite))
|
|
}
|