milvus/internal/mq/msgstream/mq_factory_test.go
Eng Zer Jun 5375161777
test: use T.TempDir to create temporary test directory (#16758)
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.

Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
	defer func() {
		if err := os.RemoveAll(dir); err != nil {
			t.Fatal(err)
		}
	}
is also tedious, but `t.TempDir` handles this for us nicely.

Fixes: #16759
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-05-04 11:35:50 +08:00

72 lines
1.8 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package msgstream
import (
"context"
"os"
"testing"
"github.com/stretchr/testify/assert"
)
func TestPmsFactory(t *testing.T) {
pmsFactory := NewPmsFactory(&Params.PulsarCfg)
ctx := context.Background()
_, err := pmsFactory.NewMsgStream(ctx)
assert.Nil(t, err)
_, err = pmsFactory.NewTtMsgStream(ctx)
assert.Nil(t, err)
_, err = pmsFactory.NewQueryMsgStream(ctx)
assert.Nil(t, err)
}
func TestRmsFactory(t *testing.T) {
defer os.Unsetenv("ROCKSMQ_PATH")
dir := t.TempDir()
rmsFactory := NewRmsFactory(dir)
ctx := context.Background()
_, err := rmsFactory.NewMsgStream(ctx)
assert.Nil(t, err)
_, err = rmsFactory.NewTtMsgStream(ctx)
assert.Nil(t, err)
_, err = rmsFactory.NewQueryMsgStream(ctx)
assert.Nil(t, err)
}
func TestKafkaFactory(t *testing.T) {
kmsFactory := NewKmsFactory(&Params.KafkaCfg)
ctx := context.Background()
_, err := kmsFactory.NewMsgStream(ctx)
assert.Nil(t, err)
_, err = kmsFactory.NewTtMsgStream(ctx)
assert.Nil(t, err)
_, err = kmsFactory.NewQueryMsgStream(ctx)
assert.Nil(t, err)
}