mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-03 04:19:18 +08:00
89541a6f68
Signed-off-by: longjiquan <jiquan.long@zilliz.com> Signed-off-by: longjiquan <jiquan.long@zilliz.com>
105 lines
3.2 KiB
Go
105 lines
3.2 KiB
Go
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/milvus-io/milvus/internal/common"
|
|
|
|
"github.com/milvus-io/milvus/internal/log"
|
|
"go.uber.org/zap"
|
|
|
|
pb "github.com/milvus-io/milvus/internal/proto/etcdpb"
|
|
|
|
"github.com/milvus-io/milvus/internal/util/typeutil"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/commonpb"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/milvuspb"
|
|
)
|
|
|
|
type dropCollectionTask struct {
|
|
baseTask
|
|
Req *milvuspb.DropCollectionRequest
|
|
}
|
|
|
|
func (t *dropCollectionTask) validate() error {
|
|
if err := CheckMsgType(t.Req.GetBase().GetMsgType(), commonpb.MsgType_DropCollection); err != nil {
|
|
return err
|
|
}
|
|
if t.core.meta.IsAlias(t.Req.GetCollectionName()) {
|
|
return fmt.Errorf("cannot drop the collection via alias = %s", t.Req.CollectionName)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (t *dropCollectionTask) Prepare(ctx context.Context) error {
|
|
return t.validate()
|
|
}
|
|
|
|
func (t *dropCollectionTask) Execute(ctx context.Context) error {
|
|
// use max ts to check if latest collection exists.
|
|
// we cannot handle case that
|
|
// dropping collection with `ts1` but a collection exists in catalog with newer ts which is bigger than `ts1`.
|
|
// fortunately, if ddls are promised to execute in sequence, then everything is OK. The `ts1` will always be latest.
|
|
collMeta, err := t.core.meta.GetCollectionByName(ctx, t.Req.GetCollectionName(), typeutil.MaxTimestamp)
|
|
if common.IsCollectionNotExistError(err) {
|
|
// make dropping collection idempotent.
|
|
log.Warn("drop non-existent collection", zap.String("collection", t.Req.GetCollectionName()))
|
|
return nil
|
|
}
|
|
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// meta cache of all aliases should also be cleaned.
|
|
aliases := t.core.meta.ListAliasesByID(collMeta.CollectionID)
|
|
|
|
ts := t.GetTs()
|
|
|
|
redoTask := newBaseRedoTask(t.core.stepExecutor)
|
|
|
|
redoTask.AddSyncStep(&expireCacheStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collectionNames: append(aliases, collMeta.Name),
|
|
collectionID: collMeta.CollectionID,
|
|
ts: ts,
|
|
opts: []expireCacheOpt{expireCacheWithDropFlag()},
|
|
})
|
|
redoTask.AddSyncStep(&changeCollectionStateStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collectionID: collMeta.CollectionID,
|
|
state: pb.CollectionState_CollectionDropping,
|
|
ts: ts,
|
|
})
|
|
|
|
redoTask.AddAsyncStep(&releaseCollectionStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collectionID: collMeta.CollectionID,
|
|
})
|
|
redoTask.AddAsyncStep(&dropIndexStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collID: collMeta.CollectionID,
|
|
partIDs: nil,
|
|
})
|
|
redoTask.AddAsyncStep(&deleteCollectionDataStep{
|
|
baseStep: baseStep{core: t.core},
|
|
coll: collMeta,
|
|
})
|
|
redoTask.AddAsyncStep(&removeDmlChannelsStep{
|
|
baseStep: baseStep{core: t.core},
|
|
pChannels: collMeta.PhysicalChannelNames,
|
|
})
|
|
redoTask.AddAsyncStep(&deleteCollectionMetaStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collectionID: collMeta.CollectionID,
|
|
// This ts is less than the ts when we notify data nodes to drop collection, but it's OK since we have already
|
|
// marked this collection as deleted. If we want to make this ts greater than the notification's ts, we should
|
|
// wrap a step who will have these three children and connect them with ts.
|
|
ts: ts,
|
|
})
|
|
|
|
return redoTask.Execute(ctx)
|
|
}
|