mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-05 05:18:52 +08:00
3f75bf1f20
#36055 Signed-off-by: lixinguo <xinguo.li@zilliz.com> Co-authored-by: lixinguo <xinguo.li@zilliz.com>
422 lines
12 KiB
Go
422 lines
12 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package compaction
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/samber/lo"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/suite"
|
|
"go.uber.org/atomic"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/internal/datanode/allocator"
|
|
"github.com/milvus-io/milvus/internal/flushcommon/io"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
"github.com/milvus-io/milvus/internal/storage"
|
|
"github.com/milvus-io/milvus/pkg/common"
|
|
"github.com/milvus-io/milvus/pkg/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/util/paramtable"
|
|
"github.com/milvus-io/milvus/pkg/util/tsoutil"
|
|
"github.com/milvus-io/milvus/pkg/util/typeutil"
|
|
)
|
|
|
|
func TestClusteringCompactionTaskSuite(t *testing.T) {
|
|
suite.Run(t, new(ClusteringCompactionTaskSuite))
|
|
}
|
|
|
|
type ClusteringCompactionTaskSuite struct {
|
|
suite.Suite
|
|
|
|
mockBinlogIO *io.MockBinlogIO
|
|
mockAlloc *allocator.MockAllocator
|
|
mockID atomic.Int64
|
|
segWriter *SegmentWriter
|
|
|
|
task *clusteringCompactionTask
|
|
|
|
plan *datapb.CompactionPlan
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) SetupSuite() {
|
|
paramtable.Get().Init(paramtable.NewBaseTable())
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) SetupTest() {
|
|
s.mockBinlogIO = io.NewMockBinlogIO(s.T())
|
|
|
|
s.mockBinlogIO.EXPECT().Upload(mock.Anything, mock.Anything).Return(nil).Maybe()
|
|
|
|
s.mockAlloc = allocator.NewMockAllocator(s.T())
|
|
s.mockID.Store(time.Now().UnixMilli())
|
|
s.mockAlloc.EXPECT().Alloc(mock.Anything).RunAndReturn(func(x uint32) (int64, int64, error) {
|
|
start := s.mockID.Load()
|
|
end := s.mockID.Add(int64(x))
|
|
return start, end, nil
|
|
}).Maybe()
|
|
s.mockAlloc.EXPECT().AllocOne().RunAndReturn(func() (int64, error) {
|
|
end := s.mockID.Add(1)
|
|
return end, nil
|
|
}).Maybe()
|
|
|
|
s.task = NewClusteringCompactionTask(context.Background(), s.mockBinlogIO, nil)
|
|
|
|
paramtable.Get().Save(paramtable.Get().CommonCfg.EntityExpirationTTL.Key, "0")
|
|
|
|
s.plan = &datapb.CompactionPlan{
|
|
PlanID: 999,
|
|
SegmentBinlogs: []*datapb.CompactionSegmentBinlogs{{
|
|
SegmentID: 100,
|
|
FieldBinlogs: nil,
|
|
Field2StatslogPaths: nil,
|
|
Deltalogs: nil,
|
|
}},
|
|
TimeoutInSeconds: 10,
|
|
Type: datapb.CompactionType_ClusteringCompaction,
|
|
}
|
|
s.task.plan = s.plan
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) SetupSubTest() {
|
|
s.SetupTest()
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TearDownTest() {
|
|
paramtable.Get().Reset(paramtable.Get().CommonCfg.EntityExpirationTTL.Key)
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestWrongCompactionType() {
|
|
s.plan.Type = datapb.CompactionType_MixCompaction
|
|
result, err := s.task.Compact()
|
|
s.Empty(result)
|
|
s.Require().Error(err)
|
|
s.Equal(true, errors.Is(err, merr.ErrIllegalCompactionPlan))
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestContextDown() {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
s.task.ctx = ctx
|
|
cancel()
|
|
result, err := s.task.Compact()
|
|
s.Empty(result)
|
|
s.Require().Error(err)
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestIsVectorClusteringKey() {
|
|
s.task.plan.Schema = genCollectionSchema()
|
|
s.task.plan.ClusteringKeyField = 100
|
|
s.task.init()
|
|
s.Equal(false, s.task.isVectorClusteringKey)
|
|
s.task.plan.ClusteringKeyField = 103
|
|
s.task.init()
|
|
s.Equal(true, s.task.isVectorClusteringKey)
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestCompactionWithEmptyBinlog() {
|
|
s.task.plan.Schema = genCollectionSchema()
|
|
s.task.plan.ClusteringKeyField = 100
|
|
_, err := s.task.Compact()
|
|
s.Require().Error(err)
|
|
s.Equal(true, errors.Is(err, merr.ErrIllegalCompactionPlan))
|
|
s.task.plan.SegmentBinlogs = []*datapb.CompactionSegmentBinlogs{}
|
|
_, err2 := s.task.Compact()
|
|
s.Require().Error(err2)
|
|
s.Equal(true, errors.Is(err2, merr.ErrIllegalCompactionPlan))
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestCompactionWithEmptySchema() {
|
|
s.task.plan.ClusteringKeyField = 100
|
|
_, err := s.task.Compact()
|
|
s.Require().Error(err)
|
|
s.Equal(true, errors.Is(err, merr.ErrIllegalCompactionPlan))
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestCompactionInit() {
|
|
s.task.plan.Schema = genCollectionSchema()
|
|
s.task.plan.ClusteringKeyField = 100
|
|
s.task.plan.SegmentBinlogs = []*datapb.CompactionSegmentBinlogs{
|
|
{
|
|
SegmentID: 100,
|
|
},
|
|
}
|
|
err := s.task.init()
|
|
s.Require().NoError(err)
|
|
s.Equal(s.task.primaryKeyField, s.task.plan.Schema.Fields[2])
|
|
s.Equal(false, s.task.isVectorClusteringKey)
|
|
s.Equal(true, s.task.memoryBufferSize > 0)
|
|
s.Equal(8, s.task.getWorkerPoolSize())
|
|
s.Equal(8, s.task.mappingPool.Cap())
|
|
s.Equal(8, s.task.flushPool.Cap())
|
|
|
|
s.task.plan.Schema = genCollectionSchema()
|
|
s.task.plan.Schema.Fields = append(s.task.plan.Schema.Fields, &schemapb.FieldSchema{
|
|
FieldID: 104,
|
|
Name: "nullableFid",
|
|
DataType: schemapb.DataType_Int64,
|
|
Nullable: true,
|
|
})
|
|
s.task.plan.ClusteringKeyField = 100
|
|
s.task.plan.SegmentBinlogs = []*datapb.CompactionSegmentBinlogs{
|
|
{
|
|
SegmentID: 100,
|
|
},
|
|
}
|
|
err = s.task.init()
|
|
s.Require().Error(err)
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestScalarCompactionNormal() {
|
|
schema := genCollectionSchema()
|
|
var segmentID int64 = 1001
|
|
segWriter, err := NewSegmentWriter(schema, 1000, segmentID, PartitionID, CollectionID)
|
|
s.Require().NoError(err)
|
|
for i := 0; i < 10240; i++ {
|
|
v := storage.Value{
|
|
PK: storage.NewInt64PrimaryKey(int64(i)),
|
|
Timestamp: int64(tsoutil.ComposeTSByTime(getMilvusBirthday(), 0)),
|
|
Value: genRow(int64(i)),
|
|
}
|
|
err = segWriter.Write(&v)
|
|
s.Require().NoError(err)
|
|
}
|
|
segWriter.FlushAndIsFull()
|
|
|
|
kvs, fBinlogs, err := serializeWrite(context.TODO(), s.mockAlloc, segWriter)
|
|
s.mockBinlogIO.EXPECT().Download(mock.Anything, mock.Anything).Return(lo.Values(kvs), nil)
|
|
|
|
s.plan.SegmentBinlogs = []*datapb.CompactionSegmentBinlogs{
|
|
{
|
|
SegmentID: segmentID,
|
|
FieldBinlogs: lo.Values(fBinlogs),
|
|
},
|
|
}
|
|
|
|
s.task.plan.Schema = genCollectionSchema()
|
|
s.task.plan.ClusteringKeyField = 100
|
|
s.task.plan.PreferSegmentRows = 2048
|
|
s.task.plan.MaxSegmentRows = 2048
|
|
s.task.plan.PreAllocatedSegmentIDs = &datapb.IDRange{
|
|
Begin: time.Now().UnixMilli(),
|
|
End: time.Now().UnixMilli() + 1000,
|
|
}
|
|
|
|
// 8+8+8+4+7+4*4=51
|
|
// 51*1024 = 52224
|
|
// writer will automatically flush after 1024 rows.
|
|
paramtable.Get().Save(paramtable.Get().DataNodeCfg.BinLogMaxSize.Key, "52223")
|
|
defer paramtable.Get().Reset(paramtable.Get().DataNodeCfg.BinLogMaxSize.Key)
|
|
|
|
compactionResult, err := s.task.Compact()
|
|
s.Require().NoError(err)
|
|
s.Equal(5, len(s.task.clusterBuffers))
|
|
s.Equal(5, len(compactionResult.GetSegments()))
|
|
totalBinlogNum := 0
|
|
totalRowNum := int64(0)
|
|
for _, fb := range compactionResult.GetSegments()[0].GetInsertLogs() {
|
|
for _, b := range fb.GetBinlogs() {
|
|
totalBinlogNum++
|
|
if fb.GetFieldID() == 100 {
|
|
totalRowNum += b.GetEntriesNum()
|
|
}
|
|
}
|
|
}
|
|
statsBinlogNum := 0
|
|
statsRowNum := int64(0)
|
|
for _, sb := range compactionResult.GetSegments()[0].GetField2StatslogPaths() {
|
|
for _, b := range sb.GetBinlogs() {
|
|
statsBinlogNum++
|
|
statsRowNum += b.GetEntriesNum()
|
|
}
|
|
}
|
|
s.Equal(2, totalBinlogNum/len(schema.GetFields()))
|
|
s.Equal(1, statsBinlogNum)
|
|
s.Equal(totalRowNum, statsRowNum)
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestCheckBuffersAfterCompaction() {
|
|
s.Run("no leak", func() {
|
|
task := &clusteringCompactionTask{clusterBuffers: []*ClusterBuffer{{}}}
|
|
|
|
s.NoError(task.checkBuffersAfterCompaction())
|
|
})
|
|
|
|
s.Run("leak binlog", func() {
|
|
task := &clusteringCompactionTask{
|
|
clusterBuffers: []*ClusterBuffer{
|
|
{
|
|
flushedBinlogs: map[typeutil.UniqueID]map[typeutil.UniqueID]*datapb.FieldBinlog{
|
|
1: {
|
|
101: {
|
|
FieldID: 101,
|
|
Binlogs: []*datapb.Binlog{{LogID: 1000}},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
s.Error(task.checkBuffersAfterCompaction())
|
|
})
|
|
}
|
|
|
|
func (s *ClusteringCompactionTaskSuite) TestGeneratePkStats() {
|
|
pkField := &schemapb.FieldSchema{
|
|
FieldID: 100,
|
|
Name: "pk",
|
|
IsPrimaryKey: true,
|
|
Description: "",
|
|
DataType: schemapb.DataType_Int64,
|
|
}
|
|
s.Run("num rows zero", func() {
|
|
task := &clusteringCompactionTask{
|
|
primaryKeyField: pkField,
|
|
}
|
|
binlogs, err := task.generatePkStats(context.Background(), 1, 0, nil)
|
|
s.Error(err)
|
|
s.Nil(binlogs)
|
|
})
|
|
|
|
s.Run("download binlogs failed", func() {
|
|
s.mockBinlogIO.EXPECT().Download(mock.Anything, mock.Anything).Return(nil, fmt.Errorf("mock error"))
|
|
task := &clusteringCompactionTask{
|
|
binlogIO: s.mockBinlogIO,
|
|
primaryKeyField: pkField,
|
|
}
|
|
binlogs, err := task.generatePkStats(context.Background(), 1, 100, [][]string{{"abc", "def"}})
|
|
s.Error(err)
|
|
s.Nil(binlogs)
|
|
})
|
|
|
|
s.Run("NewInsertBinlogIterator failed", func() {
|
|
s.mockBinlogIO.EXPECT().Download(mock.Anything, mock.Anything).Return([][]byte{[]byte("mock")}, nil)
|
|
task := &clusteringCompactionTask{
|
|
binlogIO: s.mockBinlogIO,
|
|
primaryKeyField: pkField,
|
|
}
|
|
binlogs, err := task.generatePkStats(context.Background(), 1, 100, [][]string{{"abc", "def"}})
|
|
s.Error(err)
|
|
s.Nil(binlogs)
|
|
})
|
|
|
|
s.Run("upload failed", func() {
|
|
schema := genCollectionSchema()
|
|
segWriter, err := NewSegmentWriter(schema, 1000, SegmentID, PartitionID, CollectionID)
|
|
s.Require().NoError(err)
|
|
for i := 0; i < 2000; i++ {
|
|
v := storage.Value{
|
|
PK: storage.NewInt64PrimaryKey(int64(i)),
|
|
Timestamp: int64(tsoutil.ComposeTSByTime(getMilvusBirthday(), 0)),
|
|
Value: genRow(int64(i)),
|
|
}
|
|
err = segWriter.Write(&v)
|
|
s.Require().NoError(err)
|
|
}
|
|
segWriter.FlushAndIsFull()
|
|
|
|
kvs, _, err := serializeWrite(context.TODO(), s.mockAlloc, segWriter)
|
|
s.NoError(err)
|
|
mockBinlogIO := io.NewMockBinlogIO(s.T())
|
|
mockBinlogIO.EXPECT().Download(mock.Anything, mock.Anything).Return(lo.Values(kvs), nil)
|
|
mockBinlogIO.EXPECT().Upload(mock.Anything, mock.Anything).Return(fmt.Errorf("mock error"))
|
|
task := &clusteringCompactionTask{
|
|
collectionID: CollectionID,
|
|
partitionID: PartitionID,
|
|
plan: &datapb.CompactionPlan{
|
|
Schema: genCollectionSchema(),
|
|
},
|
|
binlogIO: mockBinlogIO,
|
|
primaryKeyField: pkField,
|
|
logIDAlloc: s.mockAlloc,
|
|
}
|
|
|
|
binlogs, err := task.generatePkStats(context.Background(), 1, 100, [][]string{{"abc", "def"}})
|
|
s.Error(err)
|
|
s.Nil(binlogs)
|
|
})
|
|
}
|
|
|
|
func genRow(magic int64) map[int64]interface{} {
|
|
ts := tsoutil.ComposeTSByTime(getMilvusBirthday(), 0)
|
|
return map[int64]interface{}{
|
|
common.RowIDField: magic,
|
|
common.TimeStampField: int64(ts),
|
|
100: magic,
|
|
101: int32(magic),
|
|
102: "varchar",
|
|
103: []float32{4, 5, 6, 7},
|
|
}
|
|
}
|
|
|
|
func genCollectionSchema() *schemapb.CollectionSchema {
|
|
return &schemapb.CollectionSchema{
|
|
Name: "schema",
|
|
Description: "schema",
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
FieldID: common.RowIDField,
|
|
Name: "row_id",
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
{
|
|
FieldID: common.TimeStampField,
|
|
Name: "Timestamp",
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
{
|
|
FieldID: 100,
|
|
Name: "pk",
|
|
DataType: schemapb.DataType_Int64,
|
|
IsPrimaryKey: true,
|
|
},
|
|
{
|
|
FieldID: 101,
|
|
Name: "field_int32",
|
|
DataType: schemapb.DataType_Int32,
|
|
},
|
|
{
|
|
FieldID: 102,
|
|
Name: "field_varchar",
|
|
DataType: schemapb.DataType_VarChar,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.MaxLengthKey,
|
|
Value: "128",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
FieldID: 103,
|
|
Name: "field_float_vector",
|
|
Description: "float_vector",
|
|
DataType: schemapb.DataType_FloatVector,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.DimKey,
|
|
Value: "4",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
}
|