milvus/internal/core/src/storage/ChunkCache.h
congqixia 18c351efa6
fix: Prevent ChunkCache use absolute path in All-in-one mode (#30666)
See also #30651

Append operator of `std::filesystem::path` will replace whole path when
the param of "/" operation is an absolute path.

In "All-in-one" mode, this shall cause ChunkCache removing the original
vector data file when building chunk cache during/after load procedure.

This PR changes the ChunkCache path generation logic to a separate
function in which will check whether the file path is absolute or not.
If the file path is absolute, it removes the root path prefix and return
concatenated file path.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2024-02-19 20:58:51 +08:00

77 lines
2.4 KiB
C++

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#pragma once
#include "mmap/Column.h"
namespace milvus::storage {
extern std::map<std::string, int> ReadAheadPolicy_Map;
class ChunkCache {
public:
explicit ChunkCache(std::string path,
const std::string& read_ahead_policy,
ChunkManagerPtr cm)
: path_prefix_(std::move(path)), cm_(cm) {
auto iter = ReadAheadPolicy_Map.find(read_ahead_policy);
AssertInfo(iter != ReadAheadPolicy_Map.end(),
"unrecognized read ahead policy: {}, "
"should be one of `normal, random, sequential, "
"willneed, dontneed`",
read_ahead_policy);
read_ahead_policy_ = iter->second;
LOG_INFO("Init ChunkCache with prefix: {}, read_ahead_policy: {}",
path_prefix_,
read_ahead_policy);
}
~ChunkCache() = default;
public:
std::shared_ptr<ColumnBase>
Read(const std::string& filepath);
void
Remove(const std::string& filepath);
void
Prefetch(const std::string& filepath);
private:
std::shared_ptr<ColumnBase>
Mmap(const std::filesystem::path& path, const FieldDataPtr& field_data);
std::string
CachePath(const std::string& filepath);
private:
using ColumnTable =
std::unordered_map<std::string, std::shared_ptr<ColumnBase>>;
private:
mutable std::shared_mutex mutex_;
int read_ahead_policy_;
const std::string path_prefix_;
ChunkManagerPtr cm_;
ColumnTable columns_;
};
using ChunkCachePtr = std::shared_ptr<milvus::storage::ChunkCache>;
} // namespace milvus::storage