mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-09 23:40:06 +08:00
be6b468a3b
issue: #31696 --------- Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
1054 lines
30 KiB
Go
1054 lines
30 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"math"
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
"github.com/golang/protobuf/proto"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
"github.com/milvus-io/milvus/internal/metastore/model"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
mockrootcoord "github.com/milvus-io/milvus/internal/rootcoord/mocks"
|
|
"github.com/milvus-io/milvus/pkg/common"
|
|
"github.com/milvus-io/milvus/pkg/util"
|
|
"github.com/milvus-io/milvus/pkg/util/funcutil"
|
|
"github.com/milvus-io/milvus/pkg/util/merr"
|
|
"github.com/milvus-io/milvus/pkg/util/paramtable"
|
|
)
|
|
|
|
func Test_createCollectionTask_validate(t *testing.T) {
|
|
paramtable.Init()
|
|
t.Run("empty request", func(t *testing.T) {
|
|
task := createCollectionTask{
|
|
Req: nil,
|
|
}
|
|
err := task.validate()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("create ts", func(t *testing.T) {
|
|
task := createCollectionTask{
|
|
Req: nil,
|
|
}
|
|
{
|
|
task.SetTs(1000)
|
|
ts, err := task.getCreateTs()
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 1000, ts)
|
|
}
|
|
|
|
task.Req = &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_CreateCollection,
|
|
ReplicateInfo: &commonpb.ReplicateInfo{
|
|
IsReplicate: true,
|
|
},
|
|
},
|
|
}
|
|
{
|
|
task.SetTs(1000)
|
|
_, err := task.getCreateTs()
|
|
assert.Error(t, err)
|
|
err = task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
}
|
|
{
|
|
task.Req.Base.ReplicateInfo.MsgTimestamp = 2000
|
|
ts, err := task.getCreateTs()
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 2000, ts)
|
|
}
|
|
})
|
|
|
|
t.Run("invalid msg type", func(t *testing.T) {
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_DropCollection},
|
|
},
|
|
}
|
|
err := task.validate()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("shard num exceeds max configuration", func(t *testing.T) {
|
|
// TODO: better to have a `Set` method for ParamItem.
|
|
cfgMaxShardNum := Params.RootCoordCfg.DmlChannelNum.GetAsInt32()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
ShardsNum: cfgMaxShardNum + 1,
|
|
},
|
|
}
|
|
err := task.validate()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("shard num exceeds limit", func(t *testing.T) {
|
|
// TODO: better to have a `Set` method for ParamItem.
|
|
cfgShardLimit := paramtable.Get().ProxyCfg.MaxShardNum.GetAsInt32()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
ShardsNum: cfgShardLimit + 1,
|
|
},
|
|
}
|
|
err := task.validate()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("total collection num exceeds limit", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(2))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
1: {1, 2},
|
|
}, nil)
|
|
core := newTestCore(withMeta(meta))
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
}
|
|
err := task.validate()
|
|
assert.Error(t, err)
|
|
|
|
task = createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
err = task.validate()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("collection num per db exceeds limit", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(2))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
1: {1, 2},
|
|
}, nil)
|
|
core := newTestCore(withMeta(meta))
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
}
|
|
err := task.validate()
|
|
assert.Error(t, err)
|
|
|
|
task = createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
err = task.validate()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("collection general number exceeds limit", func(t *testing.T) {
|
|
paramtable.Get().Save(Params.RootCoordCfg.MaxGeneralCapacity.Key, strconv.Itoa(1))
|
|
defer paramtable.Get().Reset(Params.RootCoordCfg.MaxGeneralCapacity.Key)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
1: {1, 2},
|
|
}, nil)
|
|
meta.On("GetDatabaseByID",
|
|
mock.Anything, mock.Anything, mock.Anything,
|
|
).Return(&model.Database{
|
|
Name: "default",
|
|
}, nil)
|
|
meta.On("GetCollectionByID",
|
|
mock.Anything, mock.Anything, mock.Anything, mock.Anything, mock.Anything,
|
|
).Return(&model.Collection{
|
|
Name: "default",
|
|
ShardsNum: 2,
|
|
Partitions: []*model.Partition{
|
|
{
|
|
PartitionID: 1,
|
|
},
|
|
},
|
|
}, nil)
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
NumPartitions: 256,
|
|
ShardsNum: 2,
|
|
},
|
|
dbID: util.DefaultDBID,
|
|
}
|
|
err := task.validate()
|
|
assert.ErrorIs(t, err, merr.ErrGeneralCapacityExceeded)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
1: {1, 2},
|
|
}, nil)
|
|
meta.On("GetDatabaseByID", mock.Anything,
|
|
mock.Anything, mock.Anything).Return(nil, errors.New("mock"))
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
NumPartitions: 2,
|
|
ShardsNum: 2,
|
|
},
|
|
dbID: 1,
|
|
}
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
err := task.validate()
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_validateSchema(t *testing.T) {
|
|
t.Run("name mismatch", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
otherName := collectionName + "_other"
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: otherName,
|
|
}
|
|
err := task.validateSchema(schema)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("has system fields", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: RowIDFieldName},
|
|
},
|
|
}
|
|
err := task.validateSchema(schema)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("default value type mismatch", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema1 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_BinaryVector,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_BoolData{
|
|
BoolData: false,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err1 := task.validateSchema(schema1)
|
|
assert.ErrorIs(t, err1, merr.ErrParameterInvalid)
|
|
|
|
schema2 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_BinaryVector,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_IntData{
|
|
IntData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err2 := task.validateSchema(schema2)
|
|
assert.ErrorIs(t, err2, merr.ErrParameterInvalid)
|
|
|
|
schema3 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_BinaryVector,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_LongData{
|
|
LongData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err3 := task.validateSchema(schema3)
|
|
assert.ErrorIs(t, err3, merr.ErrParameterInvalid)
|
|
|
|
schema4 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_BinaryVector,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_FloatData{
|
|
FloatData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err4 := task.validateSchema(schema4)
|
|
assert.ErrorIs(t, err4, merr.ErrParameterInvalid)
|
|
|
|
schema5 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_BinaryVector,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_DoubleData{
|
|
DoubleData: 1,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err5 := task.validateSchema(schema5)
|
|
assert.ErrorIs(t, err5, merr.ErrParameterInvalid)
|
|
|
|
schema6 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_BinaryVector,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_StringData{
|
|
StringData: "a",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err6 := task.validateSchema(schema6)
|
|
assert.ErrorIs(t, err6, merr.ErrParameterInvalid)
|
|
|
|
schema7 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Int16,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_IntData{
|
|
IntData: math.MaxInt32,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err7 := task.validateSchema(schema7)
|
|
assert.ErrorIs(t, err7, merr.ErrParameterInvalid)
|
|
|
|
schema8 := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_Int8,
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_IntData{
|
|
IntData: math.MaxInt32,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err8 := task.validateSchema(schema8)
|
|
assert.ErrorIs(t, err8, merr.ErrParameterInvalid)
|
|
})
|
|
|
|
t.Run("default value length exceeds", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
DataType: schemapb.DataType_VarChar,
|
|
TypeParams: []*commonpb.KeyValuePair{
|
|
{
|
|
Key: common.MaxLengthKey,
|
|
Value: "2",
|
|
},
|
|
},
|
|
DefaultValue: &schemapb.ValueField{
|
|
Data: &schemapb.ValueField_StringData{
|
|
StringData: "abc",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
err := task.validateSchema(schema)
|
|
assert.ErrorIs(t, err, merr.ErrParameterInvalid)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
}
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Fields: []*schemapb.FieldSchema{},
|
|
}
|
|
err := task.validateSchema(schema)
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_prepareSchema(t *testing.T) {
|
|
t.Run("failed to unmarshal", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: []byte("invalid schema"),
|
|
},
|
|
}
|
|
err := task.prepareSchema()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("contain system fields", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: TimeStampFieldName},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
}
|
|
err = task.prepareSchema()
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
}
|
|
err = task.prepareSchema()
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("invalid data type", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: 200,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
task := createCollectionTask{
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
}
|
|
err = task.prepareSchema()
|
|
assert.Error(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_Prepare(t *testing.T) {
|
|
paramtable.Init()
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetDatabaseByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(model.NewDefaultDatabase(), nil)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
util.DefaultDBID: {1, 2},
|
|
}, nil)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
t.Run("invalid msg type", func(t *testing.T) {
|
|
core := newTestCore(withMeta(meta))
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_DropCollection},
|
|
},
|
|
}
|
|
err := task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("invalid schema", func(t *testing.T) {
|
|
meta.On("GetDatabaseByID", mock.Anything,
|
|
mock.Anything, mock.Anything).Return(nil, errors.New("mock"))
|
|
core := newTestCore(withMeta(meta))
|
|
collectionName := funcutil.GenRandomStr()
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: []byte("invalid schema"),
|
|
},
|
|
dbID: 1,
|
|
}
|
|
err := task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("failed to assign id", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: field1},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
meta.On("GetDatabaseByID", mock.Anything,
|
|
mock.Anything, mock.Anything).Return(nil, errors.New("mock"))
|
|
core := newTestCore(withInvalidIDAllocator(), withMeta(meta))
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
dbID: 1,
|
|
}
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
meta.On("GetDatabaseByID", mock.Anything,
|
|
mock.Anything, mock.Anything).Return(nil, errors.New("mock"))
|
|
|
|
core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta))
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{
|
|
Name: field1,
|
|
DataType: schemapb.DataType_Int64,
|
|
},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
},
|
|
dbID: 1,
|
|
}
|
|
task.Req.ShardsNum = int32(Params.RootCoordCfg.DmlChannelNum.GetAsInt() + 1) // no enough channels.
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
task.Req.ShardsNum = common.DefaultShardsNum
|
|
err = task.Prepare(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_Execute(t *testing.T) {
|
|
t.Run("add same collection with different parameters", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
ticker := newRocksMqTtSynchronizer()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName}
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(coll, nil)
|
|
|
|
core := newTestCore(withMeta(meta), withTtSynchronizer(ticker))
|
|
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
schema: &schemapb.CollectionSchema{Name: collectionName, Fields: []*schemapb.FieldSchema{{Name: field1}}},
|
|
}
|
|
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("add duplicate collection", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
ticker := newRocksMqTtSynchronizer()
|
|
shardNum := 2
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
collID := UniqueID(1)
|
|
schema := &schemapb.CollectionSchema{Name: collectionName, Fields: []*schemapb.FieldSchema{{Name: field1}}}
|
|
channels := collectionChannels{
|
|
virtualChannels: []string{funcutil.GenRandomStr(), funcutil.GenRandomStr()},
|
|
physicalChannels: pchans,
|
|
}
|
|
coll := &model.Collection{
|
|
CollectionID: collID,
|
|
Name: schema.Name,
|
|
Description: schema.Description,
|
|
AutoID: schema.AutoID,
|
|
Fields: model.UnmarshalFieldModels(schema.GetFields()),
|
|
VirtualChannelNames: channels.virtualChannels,
|
|
PhysicalChannelNames: channels.physicalChannels,
|
|
}
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(coll, nil)
|
|
|
|
core := newTestCore(withMeta(meta), withTtSynchronizer(ticker))
|
|
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
},
|
|
collID: collID,
|
|
schema: schema,
|
|
channels: channels,
|
|
}
|
|
|
|
err := task.Execute(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("failed to get start positions", func(t *testing.T) {
|
|
ticker := newTickerWithMockFailStream()
|
|
shardNum := 2
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
core := newTestCore(withTtSynchronizer(ticker))
|
|
task := &createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
channels: collectionChannels{
|
|
physicalChannels: pchans,
|
|
virtualChannels: []string{funcutil.GenRandomStr(), funcutil.GenRandomStr()},
|
|
},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
shardNum := 2
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil, errors.New("error mock GetCollectionByName"))
|
|
meta.On("AddCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.On("ChangeCollectionState",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
|
|
dc := newMockDataCoord()
|
|
dc.GetComponentStatesFunc = func(ctx context.Context) (*milvuspb.ComponentStates, error) {
|
|
return &milvuspb.ComponentStates{
|
|
State: &milvuspb.ComponentInfo{
|
|
NodeID: TestRootCoordID,
|
|
StateCode: commonpb.StateCode_Healthy,
|
|
},
|
|
SubcomponentStates: nil,
|
|
Status: merr.Success(),
|
|
}, nil
|
|
}
|
|
dc.WatchChannelsFunc = func(ctx context.Context, req *datapb.WatchChannelsRequest) (*datapb.WatchChannelsResponse, error) {
|
|
return &datapb.WatchChannelsResponse{Status: merr.Success()}, nil
|
|
}
|
|
|
|
core := newTestCore(withValidIDAllocator(),
|
|
withMeta(meta),
|
|
withTtSynchronizer(ticker),
|
|
withValidProxyManager(),
|
|
withDataCoord(dc))
|
|
core.broker = newServerBroker(core)
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: field1},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
DbName: "mock-db",
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
ShardsNum: int32(shardNum),
|
|
},
|
|
channels: collectionChannels{physicalChannels: pchans},
|
|
schema: schema,
|
|
}
|
|
|
|
err = task.Execute(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("partial error, check if undo worked", func(t *testing.T) {
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
shardNum := 2
|
|
|
|
ticker := newRocksMqTtSynchronizer()
|
|
pchans := ticker.getDmlChannelNames(shardNum)
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil, errors.New("error mock GetCollectionByName"))
|
|
meta.On("AddCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(nil)
|
|
meta.On("ChangeCollectionState",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(errors.New("error mock ChangeCollectionState"))
|
|
|
|
removeCollectionCalled := false
|
|
removeCollectionChan := make(chan struct{}, 1)
|
|
meta.On("RemoveCollection",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(func(ctx context.Context, collID UniqueID, ts Timestamp) error {
|
|
removeCollectionCalled = true
|
|
removeCollectionChan <- struct{}{}
|
|
return nil
|
|
})
|
|
|
|
broker := newMockBroker()
|
|
broker.WatchChannelsFunc = func(ctx context.Context, info *watchInfo) error {
|
|
return nil
|
|
}
|
|
|
|
unwatchChannelsCalled := false
|
|
unwatchChannelsChan := make(chan struct{}, 1)
|
|
gc := mockrootcoord.NewGarbageCollector(t)
|
|
gc.On("GcCollectionData",
|
|
mock.Anything, // context.Context
|
|
mock.Anything, // *model.Collection
|
|
).Return(func(ctx context.Context, collection *model.Collection) (ddlTs Timestamp) {
|
|
for _, pchan := range pchans {
|
|
ticker.syncedTtHistogram.update(pchan, 101)
|
|
}
|
|
unwatchChannelsCalled = true
|
|
unwatchChannelsChan <- struct{}{}
|
|
return 100
|
|
}, nil)
|
|
|
|
core := newTestCore(withValidIDAllocator(),
|
|
withMeta(meta),
|
|
withTtSynchronizer(ticker),
|
|
withGarbageCollector(gc),
|
|
withValidProxyManager(),
|
|
withBroker(broker))
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{
|
|
{Name: field1},
|
|
},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
ShardsNum: int32(shardNum),
|
|
},
|
|
channels: collectionChannels{physicalChannels: pchans},
|
|
schema: schema,
|
|
}
|
|
|
|
err = task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
|
|
// check if undo worked.
|
|
|
|
// undo watch.
|
|
<-unwatchChannelsChan
|
|
assert.True(t, unwatchChannelsCalled)
|
|
|
|
// undo adding collection.
|
|
<-removeCollectionChan
|
|
assert.True(t, removeCollectionCalled)
|
|
|
|
time.Sleep(time.Second * 2) // wait for asynchronous step done.
|
|
// undo add channels.
|
|
assert.Zero(t, len(ticker.listDmlChannels()))
|
|
})
|
|
}
|
|
|
|
func Test_createCollectionTask_PartitionKey(t *testing.T) {
|
|
paramtable.Init()
|
|
defer cleanTestEnv()
|
|
|
|
collectionName := funcutil.GenRandomStr()
|
|
field1 := funcutil.GenRandomStr()
|
|
ticker := newRocksMqTtSynchronizer()
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetDatabaseByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(model.NewDefaultDatabase(), nil)
|
|
meta.On("ListAllAvailCollections",
|
|
mock.Anything,
|
|
).Return(map[int64][]int64{
|
|
util.DefaultDBID: {1, 2},
|
|
}, nil)
|
|
meta.On("GetDatabaseByID", mock.Anything,
|
|
mock.Anything, mock.Anything).Return(nil, errors.New("mock"))
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNum.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNum.Key)
|
|
|
|
paramtable.Get().Save(Params.QuotaConfig.MaxCollectionNumPerDB.Key, strconv.Itoa(math.MaxInt64))
|
|
defer paramtable.Get().Reset(Params.QuotaConfig.MaxCollectionNumPerDB.Key)
|
|
|
|
core := newTestCore(withValidIDAllocator(), withTtSynchronizer(ticker), withMeta(meta))
|
|
|
|
partitionKeyField := &schemapb.FieldSchema{
|
|
Name: field1,
|
|
DataType: schemapb.DataType_Int64,
|
|
IsPartitionKey: true,
|
|
}
|
|
|
|
schema := &schemapb.CollectionSchema{
|
|
Name: collectionName,
|
|
Description: "",
|
|
AutoID: false,
|
|
Fields: []*schemapb.FieldSchema{partitionKeyField},
|
|
}
|
|
marshaledSchema, err := proto.Marshal(schema)
|
|
assert.NoError(t, err)
|
|
|
|
task := createCollectionTask{
|
|
baseTask: newBaseTask(context.TODO(), core),
|
|
Req: &milvuspb.CreateCollectionRequest{
|
|
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
|
|
CollectionName: collectionName,
|
|
Schema: marshaledSchema,
|
|
ShardsNum: common.DefaultShardsNum,
|
|
},
|
|
}
|
|
|
|
t.Run("without num partition", func(t *testing.T) {
|
|
task.Req.NumPartitions = 0
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("num partition too large", func(t *testing.T) {
|
|
task.Req.NumPartitions = Params.RootCoordCfg.MaxPartitionNum.GetAsInt64() + 1
|
|
err = task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
task.Req.NumPartitions = common.DefaultPartitionsWithPartitionKey
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
err = task.Prepare(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|