milvus/internal/util/importutilv2/reader.go
yihao.dai 31cf849f68
enhance: Support retriving file size from importutilv2.Reader ()
To reduce the overhead caused by listing the S3 objects, add an
interface to importutil.Reader to retrieve file sizes.

issue: https://github.com/milvus-io/milvus/issues/31532,
https://github.com/milvus-io/milvus/issues/28521

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-03-25 20:29:07 +08:00

76 lines
2.6 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package importutilv2
import (
"context"
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
"github.com/milvus-io/milvus/internal/proto/internalpb"
"github.com/milvus-io/milvus/internal/storage"
"github.com/milvus-io/milvus/internal/util/importutilv2/binlog"
"github.com/milvus-io/milvus/internal/util/importutilv2/json"
"github.com/milvus-io/milvus/internal/util/importutilv2/numpy"
"github.com/milvus-io/milvus/internal/util/importutilv2/parquet"
"github.com/milvus-io/milvus/pkg/util/merr"
)
//go:generate mockery --name=Reader --structname=MockReader --output=./ --filename=mock_reader.go --with-expecter --inpackage
type Reader interface {
// Size returns the size of the underlying file/files in bytes.
// It returns an error if the size cannot be determined.
Size() (int64, error)
// Read reads data from the underlying file/files.
// It returns the storage.InsertData and an error, if any.
Read() (*storage.InsertData, error)
// Close closes the underlying file reader.
Close()
}
func NewReader(ctx context.Context,
cm storage.ChunkManager,
schema *schemapb.CollectionSchema,
importFile *internalpb.ImportFile,
options Options,
bufferSize int,
) (Reader, error) {
if IsBackup(options) {
tsStart, tsEnd, err := ParseTimeRange(options)
if err != nil {
return nil, err
}
paths := importFile.GetPaths()
return binlog.NewReader(ctx, cm, schema, paths, tsStart, tsEnd)
}
fileType, err := GetFileType(importFile)
if err != nil {
return nil, err
}
switch fileType {
case JSON:
return json.NewReader(ctx, cm, schema, importFile.GetPaths()[0], bufferSize)
case Numpy:
return numpy.NewReader(ctx, schema, importFile.GetPaths(), cm, bufferSize)
case Parquet:
return parquet.NewReader(ctx, cm, schema, importFile.GetPaths()[0], bufferSize)
}
return nil, merr.WrapErrImportFailed("unexpected import file")
}