mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-01 19:39:21 +08:00
95 lines
2.9 KiB
Go
95 lines
2.9 KiB
Go
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"github.com/milvus-io/milvus/internal/log"
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus/internal/metastore/model"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/commonpb"
|
|
pb "github.com/milvus-io/milvus/internal/proto/etcdpb"
|
|
|
|
"github.com/milvus-io/milvus/internal/common"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/milvuspb"
|
|
)
|
|
|
|
type dropPartitionTask struct {
|
|
baseTask
|
|
Req *milvuspb.DropPartitionRequest
|
|
collMeta *model.Collection
|
|
}
|
|
|
|
func (t *dropPartitionTask) Prepare(ctx context.Context) error {
|
|
if err := CheckMsgType(t.Req.GetBase().GetMsgType(), commonpb.MsgType_DropPartition); err != nil {
|
|
return err
|
|
}
|
|
if t.Req.GetPartitionName() == Params.CommonCfg.DefaultPartitionName.GetValue() {
|
|
return fmt.Errorf("default partition cannot be deleted")
|
|
}
|
|
collMeta, err := t.core.meta.GetCollectionByName(ctx, t.Req.GetCollectionName(), t.GetTs())
|
|
if err != nil {
|
|
// Is this idempotent?
|
|
return err
|
|
}
|
|
t.collMeta = collMeta
|
|
return nil
|
|
}
|
|
|
|
func (t *dropPartitionTask) Execute(ctx context.Context) error {
|
|
partID := common.InvalidPartitionID
|
|
for _, partition := range t.collMeta.Partitions {
|
|
if partition.PartitionName == t.Req.GetPartitionName() {
|
|
partID = partition.PartitionID
|
|
break
|
|
}
|
|
}
|
|
if partID == common.InvalidPartitionID {
|
|
log.Warn("drop an non-existent partition", zap.String("collection", t.Req.GetCollectionName()), zap.String("partition", t.Req.GetPartitionName()))
|
|
// make dropping partition idempotent.
|
|
return nil
|
|
}
|
|
|
|
redoTask := newBaseRedoTask(t.core.stepExecutor)
|
|
|
|
redoTask.AddSyncStep(&expireCacheStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collectionNames: []string{t.collMeta.Name},
|
|
collectionID: t.collMeta.CollectionID,
|
|
ts: t.GetTs(),
|
|
})
|
|
redoTask.AddSyncStep(&changePartitionStateStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collectionID: t.collMeta.CollectionID,
|
|
partitionID: partID,
|
|
state: pb.PartitionState_PartitionDropping,
|
|
ts: t.GetTs(),
|
|
})
|
|
|
|
// TODO: release partition when query coord is ready.
|
|
redoTask.AddAsyncStep(&deletePartitionDataStep{
|
|
baseStep: baseStep{core: t.core},
|
|
pchans: t.collMeta.PhysicalChannelNames,
|
|
partition: &model.Partition{
|
|
PartitionID: partID,
|
|
PartitionName: t.Req.GetPartitionName(),
|
|
CollectionID: t.collMeta.CollectionID,
|
|
},
|
|
})
|
|
redoTask.AddAsyncStep(newConfirmGCStep(t.core, t.collMeta.CollectionID, partID))
|
|
redoTask.AddAsyncStep(&removePartitionMetaStep{
|
|
baseStep: baseStep{core: t.core},
|
|
collectionID: t.collMeta.CollectionID,
|
|
partitionID: partID,
|
|
// This ts is less than the ts when we notify data nodes to drop partition, but it's OK since we have already
|
|
// marked this partition as deleted. If we want to make this ts greater than the notification's ts, we should
|
|
// wrap a step who will have these children and connect them with ts.
|
|
ts: t.GetTs(),
|
|
})
|
|
|
|
return redoTask.Execute(ctx)
|
|
}
|