mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-05 21:39:19 +08:00
33c2012675
Signed-off-by: xige-16 <xi.ge@zilliz.com>
173 lines
6.6 KiB
Go
173 lines
6.6 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rootcoord
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/milvuspb"
|
|
"github.com/milvus-io/milvus/internal/metastore/model"
|
|
"github.com/milvus-io/milvus/internal/proto/etcdpb"
|
|
mockrootcoord "github.com/milvus-io/milvus/internal/rootcoord/mocks"
|
|
"github.com/milvus-io/milvus/pkg/util/funcutil"
|
|
)
|
|
|
|
func Test_createPartitionTask_Prepare(t *testing.T) {
|
|
t.Run("invalid msg type", func(t *testing.T) {
|
|
task := &createPartitionTask{
|
|
Req: &milvuspb.CreatePartitionRequest{Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_DropCollection}},
|
|
}
|
|
err := task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("failed to get collection meta", func(t *testing.T) {
|
|
core := newTestCore(withInvalidMeta())
|
|
task := &createPartitionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreatePartitionRequest{Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreatePartition}},
|
|
}
|
|
err := task.Prepare(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName}
|
|
|
|
meta := mockrootcoord.NewIMetaTable(t)
|
|
meta.On("GetCollectionByName",
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
mock.Anything,
|
|
).Return(coll.Clone(), nil)
|
|
|
|
core := newTestCore(withMeta(meta))
|
|
task := &createPartitionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
Req: &milvuspb.CreatePartitionRequest{Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreatePartition}},
|
|
}
|
|
err := task.Prepare(context.Background())
|
|
assert.NoError(t, err)
|
|
assert.True(t, coll.Equal(*task.collMeta))
|
|
})
|
|
}
|
|
|
|
func Test_createPartitionTask_Execute(t *testing.T) {
|
|
t.Run("create duplicate partition", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
partitionName := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName, Partitions: []*model.Partition{{PartitionName: partitionName}}}
|
|
task := &createPartitionTask{
|
|
collMeta: coll,
|
|
Req: &milvuspb.CreatePartitionRequest{CollectionName: collectionName, PartitionName: partitionName},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
|
|
t.Run("create too many partitions", func(t *testing.T) {
|
|
cfgMaxPartitionNum := Params.RootCoordCfg.MaxPartitionNum.GetAsInt()
|
|
partitions := make([]*model.Partition, 0, cfgMaxPartitionNum)
|
|
for i := 0; i < cfgMaxPartitionNum; i++ {
|
|
partitions = append(partitions, &model.Partition{})
|
|
}
|
|
collectionName := funcutil.GenRandomStr()
|
|
partitionName := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName, Partitions: partitions}
|
|
task := &createPartitionTask{
|
|
collMeta: coll,
|
|
Req: &milvuspb.CreatePartitionRequest{CollectionName: collectionName, PartitionName: partitionName},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("failed to allocate partition id", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
partitionName := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName, Partitions: []*model.Partition{}}
|
|
core := newTestCore(withInvalidIDAllocator())
|
|
task := &createPartitionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
collMeta: coll,
|
|
Req: &milvuspb.CreatePartitionRequest{CollectionName: collectionName, PartitionName: partitionName},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("failed to expire cache", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
partitionName := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName, Partitions: []*model.Partition{}}
|
|
core := newTestCore(withValidIDAllocator(), withInvalidProxyManager())
|
|
task := &createPartitionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
collMeta: coll,
|
|
Req: &milvuspb.CreatePartitionRequest{CollectionName: collectionName, PartitionName: partitionName},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("failed to add partition meta", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
partitionName := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName, Partitions: []*model.Partition{}}
|
|
core := newTestCore(withValidIDAllocator(), withValidProxyManager(), withInvalidMeta())
|
|
task := &createPartitionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
collMeta: coll,
|
|
Req: &milvuspb.CreatePartitionRequest{CollectionName: collectionName, PartitionName: partitionName},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
t.Run("normal case", func(t *testing.T) {
|
|
collectionName := funcutil.GenRandomStr()
|
|
partitionName := funcutil.GenRandomStr()
|
|
coll := &model.Collection{Name: collectionName, Partitions: []*model.Partition{}}
|
|
meta := newMockMetaTable()
|
|
meta.AddPartitionFunc = func(ctx context.Context, partition *model.Partition) error {
|
|
return nil
|
|
}
|
|
meta.ChangePartitionStateFunc = func(ctx context.Context, collectionID UniqueID, partitionID UniqueID, state etcdpb.PartitionState, ts Timestamp) error {
|
|
return nil
|
|
}
|
|
b := newMockBroker()
|
|
b.SyncNewCreatedPartitionFunc = func(ctx context.Context, collectionID UniqueID, partitionID UniqueID) error {
|
|
return nil
|
|
}
|
|
core := newTestCore(withValidIDAllocator(), withValidProxyManager(), withMeta(meta), withBroker(b))
|
|
task := &createPartitionTask{
|
|
baseTask: newBaseTask(context.Background(), core),
|
|
collMeta: coll,
|
|
Req: &milvuspb.CreatePartitionRequest{CollectionName: collectionName, PartitionName: partitionName},
|
|
}
|
|
err := task.Execute(context.Background())
|
|
assert.NoError(t, err)
|
|
})
|
|
}
|