mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-04 12:59:23 +08:00
4bda6c33ad
all the vector dimension check should happen on collection creation but not index build fix #30285 Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
52 lines
1.7 KiB
Go
52 lines
1.7 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package indexparamcheck
|
|
|
|
import (
|
|
"fmt"
|
|
"math"
|
|
|
|
"github.com/cockroachdb/errors"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
|
|
)
|
|
|
|
type baseChecker struct{}
|
|
|
|
func (c baseChecker) CheckTrain(params map[string]string) error {
|
|
// vector dimension should be checked on collection creation. this is just some basic check
|
|
if !CheckIntByRange(params, DIM, 1, math.MaxInt) {
|
|
return fmt.Errorf("failed to check vector dimension, should be larger than 0 and smaller than math.MaxInt")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// CheckValidDataType check whether the field data type is supported for the index type
|
|
func (c baseChecker) CheckValidDataType(dType schemapb.DataType) error {
|
|
return nil
|
|
}
|
|
|
|
func (c baseChecker) SetDefaultMetricTypeIfNotExist(m map[string]string) {}
|
|
|
|
func (c baseChecker) StaticCheck(params map[string]string) error {
|
|
return errors.New("unsupported index type")
|
|
}
|
|
|
|
func newBaseChecker() IndexChecker {
|
|
return &baseChecker{}
|
|
}
|