mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-04 12:59:23 +08:00
8123bea1ae
issue: #34095 When a new query node comes online, the segment_checker, channel_checker, and balance_checker simultaneously attempt to allocate segments to it. If this occurs during the execution of a load task and the distribution of the new query node hasn't been updated, the query coordinator may mistakenly view the new query node as empty. As a result, it assigns segments or channels to it, potentially overloading the new query node with more segments or channels than expected. This PR measures the workload of the executing tasks on the target query node to prevent assigning an excessive number of segments to it. --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
152 lines
5.1 KiB
Go
152 lines
5.1 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package balance
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
|
|
"github.com/blang/semver/v4"
|
|
"github.com/samber/lo"
|
|
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/meta"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/session"
|
|
"github.com/milvus-io/milvus/internal/querycoordv2/task"
|
|
)
|
|
|
|
type SegmentAssignPlan struct {
|
|
Segment *meta.Segment
|
|
Replica *meta.Replica
|
|
From int64 // -1 if empty
|
|
To int64
|
|
}
|
|
|
|
func (segPlan *SegmentAssignPlan) ToString() string {
|
|
return fmt.Sprintf("SegmentPlan:[collectionID: %d, replicaID: %d, segmentID: %d, from: %d, to: %d]\n",
|
|
segPlan.Segment.CollectionID, segPlan.Replica.GetID(), segPlan.Segment.ID, segPlan.From, segPlan.To)
|
|
}
|
|
|
|
type ChannelAssignPlan struct {
|
|
Channel *meta.DmChannel
|
|
Replica *meta.Replica
|
|
From int64
|
|
To int64
|
|
}
|
|
|
|
func (chanPlan *ChannelAssignPlan) ToString() string {
|
|
return fmt.Sprintf("ChannelPlan:[collectionID: %d, channel: %s, replicaID: %d, from: %d, to: %d]\n",
|
|
chanPlan.Channel.CollectionID, chanPlan.Channel.ChannelName, chanPlan.Replica.GetID(), chanPlan.From, chanPlan.To)
|
|
}
|
|
|
|
type Balance interface {
|
|
AssignSegment(collectionID int64, segments []*meta.Segment, nodes []int64, manualBalance bool) []SegmentAssignPlan
|
|
AssignChannel(channels []*meta.DmChannel, nodes []int64, manualBalance bool) []ChannelAssignPlan
|
|
BalanceReplica(replica *meta.Replica) ([]SegmentAssignPlan, []ChannelAssignPlan)
|
|
}
|
|
|
|
type RoundRobinBalancer struct {
|
|
scheduler task.Scheduler
|
|
nodeManager *session.NodeManager
|
|
}
|
|
|
|
func (b *RoundRobinBalancer) AssignSegment(collectionID int64, segments []*meta.Segment, nodes []int64, manualBalance bool) []SegmentAssignPlan {
|
|
// skip out suspend node and stopping node during assignment, but skip this check for manual balance
|
|
if !manualBalance {
|
|
nodes = lo.Filter(nodes, func(node int64, _ int) bool {
|
|
info := b.nodeManager.Get(node)
|
|
return info != nil && info.GetState() == session.NodeStateNormal
|
|
})
|
|
}
|
|
|
|
nodesInfo := b.getNodes(nodes)
|
|
if len(nodesInfo) == 0 {
|
|
return nil
|
|
}
|
|
sort.Slice(nodesInfo, func(i, j int) bool {
|
|
cnt1, cnt2 := nodesInfo[i].SegmentCnt(), nodesInfo[j].SegmentCnt()
|
|
id1, id2 := nodesInfo[i].ID(), nodesInfo[j].ID()
|
|
delta1, delta2 := b.scheduler.GetSegmentTaskDelta(id1, -1), b.scheduler.GetSegmentTaskDelta(id2, -1)
|
|
return cnt1+delta1 < cnt2+delta2
|
|
})
|
|
ret := make([]SegmentAssignPlan, 0, len(segments))
|
|
for i, s := range segments {
|
|
plan := SegmentAssignPlan{
|
|
Segment: s,
|
|
From: -1,
|
|
To: nodesInfo[i%len(nodesInfo)].ID(),
|
|
}
|
|
ret = append(ret, plan)
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func (b *RoundRobinBalancer) AssignChannel(channels []*meta.DmChannel, nodes []int64, manualBalance bool) []ChannelAssignPlan {
|
|
// skip out suspend node and stopping node during assignment, but skip this check for manual balance
|
|
if !manualBalance {
|
|
versionRangeFilter := semver.MustParseRange(">2.3.x")
|
|
nodes = lo.Filter(nodes, func(node int64, _ int) bool {
|
|
info := b.nodeManager.Get(node)
|
|
// balance channel to qn with version < 2.4 is not allowed since l0 segment supported
|
|
// if watch channel on qn with version < 2.4, it may cause delete data loss
|
|
return info != nil && info.GetState() == session.NodeStateNormal && versionRangeFilter(info.Version())
|
|
})
|
|
}
|
|
nodesInfo := b.getNodes(nodes)
|
|
if len(nodesInfo) == 0 {
|
|
return nil
|
|
}
|
|
sort.Slice(nodesInfo, func(i, j int) bool {
|
|
cnt1, cnt2 := nodesInfo[i].ChannelCnt(), nodesInfo[j].ChannelCnt()
|
|
id1, id2 := nodesInfo[i].ID(), nodesInfo[j].ID()
|
|
delta1, delta2 := b.scheduler.GetChannelTaskDelta(id1, -1), b.scheduler.GetChannelTaskDelta(id2, -1)
|
|
return cnt1+delta1 < cnt2+delta2
|
|
})
|
|
ret := make([]ChannelAssignPlan, 0, len(channels))
|
|
for i, c := range channels {
|
|
plan := ChannelAssignPlan{
|
|
Channel: c,
|
|
From: -1,
|
|
To: nodesInfo[i%len(nodesInfo)].ID(),
|
|
}
|
|
ret = append(ret, plan)
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func (b *RoundRobinBalancer) BalanceReplica(replica *meta.Replica) ([]SegmentAssignPlan, []ChannelAssignPlan) {
|
|
// TODO by chun.han
|
|
return nil, nil
|
|
}
|
|
|
|
func (b *RoundRobinBalancer) getNodes(nodes []int64) []*session.NodeInfo {
|
|
ret := make([]*session.NodeInfo, 0, len(nodes))
|
|
for _, n := range nodes {
|
|
node := b.nodeManager.Get(n)
|
|
if node != nil && !node.IsStoppingState() {
|
|
ret = append(ret, node)
|
|
}
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func NewRoundRobinBalancer(scheduler task.Scheduler, nodeManager *session.NodeManager) *RoundRobinBalancer {
|
|
return &RoundRobinBalancer{
|
|
scheduler: scheduler,
|
|
nodeManager: nodeManager,
|
|
}
|
|
}
|