mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-04 21:09:06 +08:00
6c5be83ea1
This PR mainly did the following 3 things: - Refactor NewEtcdKV API - Add unittests for `kv/etcd/`, raise the coverage up to 94% - Correct some APIs from version to revision The old NewEtcdKV() API took `clientv3.Client` as one of the input, making everyone who using this API had to create a new `clientv3.Client`. So there're a lot of repeated codes everywhere. Meanwhile, someplace didn't even check whether the `clientv3.New()` returned error or not, and the old API also didn't check whether the clientv3.Client was Nil. This caused issue#6955. Ectd's version and revision have nothing alike, they represent different concepts, but our APIs kind of mixed them all up. So I correct those APIs' names. Resolves: #6955 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
68 lines
1.9 KiB
Go
68 lines
1.9 KiB
Go
// Copyright (C) 2019-2020 Zilliz. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the License
|
|
// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
|
|
// or implied. See the License for the specific language governing permissions and limitations under the License.
|
|
|
|
package allocator
|
|
|
|
import (
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/milvus-io/milvus/internal/util/tsoutil"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
var gTestIDAllocator *GlobalIDAllocator
|
|
|
|
func TestGlobalTSOAllocator_All(t *testing.T) {
|
|
endpoints := os.Getenv("ETCD_ENDPOINTS")
|
|
if endpoints == "" {
|
|
endpoints = "localhost:2379"
|
|
}
|
|
etcdEndpoints := strings.Split(endpoints, ",")
|
|
etcdKV, err := tsoutil.NewTSOKVBase(etcdEndpoints, "/test/root/kv", "gidTest")
|
|
assert.NoError(t, err)
|
|
|
|
gTestIDAllocator = NewGlobalIDAllocator("idTimestamp", etcdKV)
|
|
|
|
t.Run("Initialize", func(t *testing.T) {
|
|
err := gTestIDAllocator.Initialize()
|
|
assert.Nil(t, err)
|
|
})
|
|
|
|
t.Run("AllocOne", func(t *testing.T) {
|
|
one, err := gTestIDAllocator.AllocOne()
|
|
assert.Nil(t, err)
|
|
ano, err := gTestIDAllocator.AllocOne()
|
|
assert.Nil(t, err)
|
|
assert.NotEqual(t, one, ano)
|
|
})
|
|
|
|
t.Run("Alloc", func(t *testing.T) {
|
|
count := uint32(2 << 10)
|
|
idStart, idEnd, err := gTestIDAllocator.Alloc(count)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, count, uint32(idEnd-idStart))
|
|
})
|
|
|
|
t.Run("Alloc2", func(t *testing.T) {
|
|
count1 := uint32(2 << 18)
|
|
id1, err := gTestIDAllocator.allocator.GenerateTSO(count1)
|
|
assert.Nil(t, err)
|
|
|
|
count2 := uint32(2 << 8)
|
|
id2, err := gTestIDAllocator.allocator.GenerateTSO(count2)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, id2-id1, uint64(count2))
|
|
|
|
})
|
|
}
|