mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-05 13:28:49 +08:00
83da08c388
See also #32165 `ChannelManager.Match` is a frequent operation for datacoord. When the collection number is large, iteration over all channels will cost lots of CPU time and time consuming. This PR change the data structure storing datanode-channel info to map avoiding this iteration when checking channel existence. --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
188 lines
4.9 KiB
Go
188 lines
4.9 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datacoord
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
"testing"
|
|
|
|
"github.com/golang/protobuf/proto"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/mock"
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/milvus-io/milvus/internal/kv"
|
|
"github.com/milvus-io/milvus/internal/kv/mocks"
|
|
"github.com/milvus-io/milvus/internal/kv/predicates"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/metrics"
|
|
"github.com/milvus-io/milvus/pkg/util/testutils"
|
|
)
|
|
|
|
func genNodeChannelInfos(id int64, num int) *NodeChannelInfo {
|
|
channels := make([]RWChannel, 0, num)
|
|
for i := 0; i < num; i++ {
|
|
name := fmt.Sprintf("ch%d", i)
|
|
channels = append(channels, &channelMeta{Name: name, CollectionID: 1, WatchInfo: &datapb.ChannelWatchInfo{}})
|
|
}
|
|
return NewNodeChannelInfo(id, channels...)
|
|
}
|
|
|
|
func genChannelOperations(from, to int64, num int) *ChannelOpSet {
|
|
channels := make([]RWChannel, 0, num)
|
|
for i := 0; i < num; i++ {
|
|
name := fmt.Sprintf("ch%d", i)
|
|
channels = append(channels, &channelMeta{Name: name, CollectionID: 1, WatchInfo: &datapb.ChannelWatchInfo{}})
|
|
}
|
|
|
|
ops := NewChannelOpSet(
|
|
NewAddOp(to, channels...),
|
|
NewDeleteOp(from, channels...),
|
|
)
|
|
return ops
|
|
}
|
|
|
|
func TestChannelStore_Update(t *testing.T) {
|
|
txnKv := mocks.NewTxnKV(t)
|
|
txnKv.EXPECT().MultiSaveAndRemove(mock.Anything, mock.Anything).Run(func(saves map[string]string, removals []string, preds ...predicates.Predicate) {
|
|
assert.False(t, len(saves)+len(removals) > 64, "too many operations")
|
|
}).Return(nil)
|
|
|
|
type fields struct {
|
|
store kv.TxnKV
|
|
channelsInfo map[int64]*NodeChannelInfo
|
|
}
|
|
type args struct {
|
|
opSet *ChannelOpSet
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
wantErr bool
|
|
}{
|
|
{
|
|
"test more than 128 operations",
|
|
fields{
|
|
txnKv,
|
|
map[int64]*NodeChannelInfo{
|
|
1: genNodeChannelInfos(1, 500),
|
|
2: NewNodeChannelInfo(2),
|
|
},
|
|
},
|
|
args{
|
|
genChannelOperations(1, 2, 250),
|
|
},
|
|
false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
c := &ChannelStore{
|
|
store: tt.fields.store,
|
|
channelsInfo: tt.fields.channelsInfo,
|
|
}
|
|
err := c.Update(tt.args.opSet)
|
|
assert.Equal(t, tt.wantErr, err != nil)
|
|
})
|
|
}
|
|
}
|
|
|
|
type ChannelStoreReloadSuite struct {
|
|
testutils.PromMetricsSuite
|
|
|
|
mockTxn *mocks.TxnKV
|
|
}
|
|
|
|
func (suite *ChannelStoreReloadSuite) SetupTest() {
|
|
suite.mockTxn = mocks.NewTxnKV(suite.T())
|
|
}
|
|
|
|
func (suite *ChannelStoreReloadSuite) generateWatchInfo(name string, state datapb.ChannelWatchState) *datapb.ChannelWatchInfo {
|
|
return &datapb.ChannelWatchInfo{
|
|
Vchan: &datapb.VchannelInfo{
|
|
ChannelName: name,
|
|
},
|
|
State: state,
|
|
}
|
|
}
|
|
|
|
func (suite *ChannelStoreReloadSuite) TestReload() {
|
|
type item struct {
|
|
nodeID int64
|
|
channelName string
|
|
}
|
|
type testCase struct {
|
|
tag string
|
|
items []item
|
|
expect map[int64]int
|
|
}
|
|
|
|
cases := []testCase{
|
|
{
|
|
tag: "empty",
|
|
items: []item{},
|
|
expect: map[int64]int{},
|
|
},
|
|
{
|
|
tag: "normal",
|
|
items: []item{
|
|
{nodeID: 1, channelName: "dml1_v0"},
|
|
{nodeID: 1, channelName: "dml2_v1"},
|
|
{nodeID: 2, channelName: "dml3_v0"},
|
|
},
|
|
expect: map[int64]int{1: 2, 2: 1},
|
|
},
|
|
{
|
|
tag: "buffer",
|
|
items: []item{
|
|
{nodeID: bufferID, channelName: "dml1_v0"},
|
|
},
|
|
expect: map[int64]int{bufferID: 1},
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
suite.Run(tc.tag, func() {
|
|
suite.mockTxn.ExpectedCalls = nil
|
|
|
|
var keys, values []string
|
|
for _, item := range tc.items {
|
|
keys = append(keys, fmt.Sprintf("channel_store/%d/%s", item.nodeID, item.channelName))
|
|
info := suite.generateWatchInfo(item.channelName, datapb.ChannelWatchState_WatchSuccess)
|
|
bs, err := proto.Marshal(info)
|
|
suite.Require().NoError(err)
|
|
values = append(values, string(bs))
|
|
}
|
|
suite.mockTxn.EXPECT().LoadWithPrefix(mock.AnythingOfType("string")).Return(keys, values, nil)
|
|
|
|
store := NewChannelStore(suite.mockTxn)
|
|
err := store.Reload()
|
|
suite.Require().NoError(err)
|
|
|
|
for nodeID, expect := range tc.expect {
|
|
suite.MetricsEqual(metrics.DataCoordDmlChannelNum.WithLabelValues(strconv.FormatInt(nodeID, 10)), float64(expect))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestChannelStore(t *testing.T) {
|
|
suite.Run(t, new(ChannelStoreReloadSuite))
|
|
}
|