milvus/internal/querycoord/task_util.go
wayblink 6fd83464cd
Fix watchDmChannel may be out-of-date after compaction issue and add context (#18681)
Signed-off-by: wayblink <anyang.wang@zilliz.com>

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2022-08-23 17:44:56 +08:00

161 lines
6.0 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package querycoord
import (
"context"
"github.com/golang/protobuf/proto"
"github.com/milvus-io/milvus/internal/log"
"github.com/milvus-io/milvus/internal/proto/datapb"
"github.com/milvus-io/milvus/internal/proto/querypb"
"github.com/milvus-io/milvus/internal/util/retry"
"go.uber.org/zap"
)
// generateFullWatchDmChannelsRequest fill the WatchDmChannelsRequest by get segment infos from meta broker
func generateFullWatchDmChannelsRequest(ctx context.Context, broker *globalMetaBroker, request *querypb.WatchDmChannelsRequest) (*querypb.WatchDmChannelsRequest, error) {
cloned := proto.Clone(request).(*querypb.WatchDmChannelsRequest)
vChannels := cloned.GetInfos()
// for upgrade compatibility from 2.0.2
for _, vChannel := range vChannels {
reviseVChannelInfo(vChannel)
}
vChannelDict := make(map[string]bool, len(vChannels))
for _, info := range vChannels {
vChannelDict[info.ChannelName] = true
}
var segmentInfos []*datapb.SegmentInfo
// if the return segmentInfos is less than required, this may because the segment is compacted.
// refresh the vchannels and segmentInfos needed.
retryFunc := func() error {
newVChannels := make([]*datapb.VchannelInfo, 0)
newSegmentIds := make([]int64, 0)
newVChannelDict := make(map[string]bool)
for _, partitionID := range request.GetLoadMeta().GetPartitionIDs() {
partitionVChannels, _, err := broker.getRecoveryInfo(ctx, request.GetCollectionID(), partitionID)
if err != nil {
log.Error("GetRecoveryInfo failed, retrying...", zap.Error(err))
return err
}
for _, vchannel := range partitionVChannels {
if vChannelDict[vchannel.GetChannelName()] && !newVChannelDict[vchannel.GetChannelName()] {
newVChannels = append(newVChannels, vchannel)
newVChannelDict[vchannel.GetChannelName()] = true
}
}
}
for _, vChannel := range newVChannels {
newSegmentIds = append(newSegmentIds, vChannel.FlushedSegmentIds...)
newSegmentIds = append(newSegmentIds, vChannel.UnflushedSegmentIds...)
newSegmentIds = append(newSegmentIds, vChannel.DroppedSegmentIds...)
}
newSegmentInfos, err := broker.getDataSegmentInfosByIDs(ctx, newSegmentIds)
if err != nil {
log.Error("Get Vchannel SegmentInfos failed, retrying...", zap.Error(err))
return err
}
cloned.Infos = newVChannels
segmentInfos = newSegmentInfos
return nil
}
// fill segmentInfos
segmentIds := make([]int64, 0)
for _, vChannel := range vChannels {
segmentIds = append(segmentIds, vChannel.FlushedSegmentIds...)
segmentIds = append(segmentIds, vChannel.UnflushedSegmentIds...)
segmentIds = append(segmentIds, vChannel.DroppedSegmentIds...)
}
segmentInfos, err := broker.getDataSegmentInfosByIDs(ctx, segmentIds)
if err != nil {
log.Error("Get Vchannel SegmentInfos failed", zap.Error(err))
retryErr := retry.Do(ctx, retryFunc, retry.Attempts(20))
if retryErr != nil {
log.Error("Get Vchannel SegmentInfos failed after retry", zap.Error(retryErr))
return nil, retryErr
}
}
segmentDict := make(map[int64]*datapb.SegmentInfo)
for _, info := range segmentInfos {
segmentDict[info.ID] = info
}
cloned.SegmentInfos = segmentDict
return cloned, nil
}
// thinWatchDmChannelsRequest will return a thin version of WatchDmChannelsRequest
// the thin version is used for storage because the complete version may be too large
func thinWatchDmChannelsRequest(request *querypb.WatchDmChannelsRequest) *querypb.WatchDmChannelsRequest {
cloned := proto.Clone(request).(*querypb.WatchDmChannelsRequest)
cloned.SegmentInfos = make(map[int64]*datapb.SegmentInfo)
return cloned
}
// reviseVChannelInfo will revise the datapb.VchannelInfo for upgrade compatibility from 2.0.2
func reviseVChannelInfo(vChannel *datapb.VchannelInfo) {
removeDuplicateSegmentIDFn := func(ids []int64) []int64 {
result := make([]int64, 0, len(ids))
existDict := make(map[int64]bool)
for _, id := range ids {
if _, ok := existDict[id]; !ok {
existDict[id] = true
result = append(result, id)
}
}
return result
}
if vChannel == nil {
return
}
// if the segment infos is not nil(generated by 2.0.2), append the corresponding IDs to segmentIDs
// and remove the segment infos, remove deplicate ids in case there are some mixed situations
if vChannel.FlushedSegments != nil && len(vChannel.FlushedSegments) > 0 {
for _, segment := range vChannel.FlushedSegments {
vChannel.FlushedSegmentIds = append(vChannel.GetFlushedSegmentIds(), segment.GetID())
}
vChannel.FlushedSegments = []*datapb.SegmentInfo{}
}
vChannel.FlushedSegmentIds = removeDuplicateSegmentIDFn(vChannel.GetFlushedSegmentIds())
if vChannel.UnflushedSegments != nil && len(vChannel.UnflushedSegments) > 0 {
for _, segment := range vChannel.UnflushedSegments {
vChannel.UnflushedSegmentIds = append(vChannel.GetUnflushedSegmentIds(), segment.GetID())
}
vChannel.UnflushedSegments = []*datapb.SegmentInfo{}
}
vChannel.UnflushedSegmentIds = removeDuplicateSegmentIDFn(vChannel.GetUnflushedSegmentIds())
if vChannel.DroppedSegments != nil && len(vChannel.DroppedSegments) > 0 {
for _, segment := range vChannel.DroppedSegments {
vChannel.DroppedSegmentIds = append(vChannel.GetDroppedSegmentIds(), segment.GetID())
}
vChannel.DroppedSegments = []*datapb.SegmentInfo{}
}
vChannel.DroppedSegmentIds = removeDuplicateSegmentIDFn(vChannel.GetDroppedSegmentIds())
}