mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-11-30 19:08:30 +08:00
321c5c32e3
This PR: - Separates compaction scheduler and check results loop So that slow in check-loop doesn't influence execution. - Cleans compaction tasks when drop a vchannel so dropped-channel's compaction tasks won't be checked over and over again. - Skips meta change when meta's already changed, avoid panic - Remove not inuse injectDone(bool) parameter See also: #28628, #28209 --------- Signed-off-by: yangxuan <xuan.yang@zilliz.com>
166 lines
4.9 KiB
Go
166 lines
4.9 KiB
Go
// Licensed to the LF AI & Data foundation under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package datanode
|
|
|
|
import (
|
|
"context"
|
|
|
|
"go.uber.org/zap"
|
|
|
|
"github.com/milvus-io/milvus-proto/go-api/v2/commonpb"
|
|
"github.com/milvus-io/milvus/internal/proto/datapb"
|
|
"github.com/milvus-io/milvus/pkg/log"
|
|
"github.com/milvus-io/milvus/pkg/util/typeutil"
|
|
)
|
|
|
|
const (
|
|
maxTaskNum = 1024
|
|
)
|
|
|
|
type compactionExecutor struct {
|
|
executing *typeutil.ConcurrentMap[int64, compactor] // planID to compactor
|
|
completedCompactor *typeutil.ConcurrentMap[int64, compactor] // planID to compactor
|
|
completed *typeutil.ConcurrentMap[int64, *datapb.CompactionPlanResult] // planID to CompactionPlanResult
|
|
taskCh chan compactor
|
|
dropped *typeutil.ConcurrentSet[string] // vchannel dropped
|
|
}
|
|
|
|
func newCompactionExecutor() *compactionExecutor {
|
|
return &compactionExecutor{
|
|
executing: typeutil.NewConcurrentMap[int64, compactor](),
|
|
completedCompactor: typeutil.NewConcurrentMap[int64, compactor](),
|
|
completed: typeutil.NewConcurrentMap[int64, *datapb.CompactionPlanResult](),
|
|
taskCh: make(chan compactor, maxTaskNum),
|
|
dropped: typeutil.NewConcurrentSet[string](),
|
|
}
|
|
}
|
|
|
|
func (c *compactionExecutor) execute(task compactor) {
|
|
c.taskCh <- task
|
|
c.toExecutingState(task)
|
|
}
|
|
|
|
func (c *compactionExecutor) toExecutingState(task compactor) {
|
|
c.executing.Insert(task.getPlanID(), task)
|
|
}
|
|
|
|
func (c *compactionExecutor) toCompleteState(task compactor) {
|
|
task.complete()
|
|
c.executing.GetAndRemove(task.getPlanID())
|
|
}
|
|
|
|
func (c *compactionExecutor) injectDone(planID UniqueID) {
|
|
c.completed.GetAndRemove(planID)
|
|
task, loaded := c.completedCompactor.GetAndRemove(planID)
|
|
if loaded {
|
|
task.injectDone()
|
|
}
|
|
}
|
|
|
|
// These two func are bounded for waitGroup
|
|
func (c *compactionExecutor) executeWithState(task compactor) {
|
|
go c.executeTask(task)
|
|
}
|
|
|
|
func (c *compactionExecutor) start(ctx context.Context) {
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
return
|
|
case task := <-c.taskCh:
|
|
c.executeWithState(task)
|
|
}
|
|
}
|
|
}
|
|
|
|
func (c *compactionExecutor) executeTask(task compactor) {
|
|
defer func() {
|
|
c.toCompleteState(task)
|
|
}()
|
|
|
|
log.Info("start to execute compaction", zap.Int64("planID", task.getPlanID()), zap.Int64("Collection", task.getCollection()), zap.String("channel", task.getChannelName()))
|
|
|
|
result, err := task.compact()
|
|
if err != nil {
|
|
log.Warn("compaction task failed",
|
|
zap.Int64("planID", task.getPlanID()),
|
|
zap.Error(err),
|
|
)
|
|
} else {
|
|
c.completed.Insert(result.GetPlanID(), result)
|
|
c.completedCompactor.Insert(result.GetPlanID(), task)
|
|
}
|
|
|
|
log.Info("end to execute compaction", zap.Int64("planID", task.getPlanID()))
|
|
}
|
|
|
|
func (c *compactionExecutor) stopTask(planID UniqueID) {
|
|
task, loaded := c.executing.GetAndRemove(planID)
|
|
if loaded {
|
|
log.Warn("compaction executor stop task", zap.Int64("planID", planID), zap.String("vChannelName", task.getChannelName()))
|
|
task.stop()
|
|
}
|
|
}
|
|
|
|
func (c *compactionExecutor) isValidChannel(channel string) bool {
|
|
// if vchannel marked dropped, compaction should not proceed
|
|
return !c.dropped.Contain(channel)
|
|
}
|
|
|
|
func (c *compactionExecutor) clearTasksByChannel(channel string) {
|
|
c.dropped.Insert(channel)
|
|
|
|
// stop executing tasks of channel
|
|
c.executing.Range(func(planID int64, task compactor) bool {
|
|
if task.getChannelName() == channel {
|
|
c.stopTask(planID)
|
|
}
|
|
return true
|
|
})
|
|
|
|
// remove all completed plans of channel
|
|
c.completed.Range(func(planID int64, result *datapb.CompactionPlanResult) bool {
|
|
if result.GetChannel() == channel {
|
|
c.injectDone(planID)
|
|
log.Info("remove compaction results for dropped channel",
|
|
zap.String("channel", channel),
|
|
zap.Int64("planID", planID))
|
|
}
|
|
return true
|
|
})
|
|
}
|
|
|
|
func (c *compactionExecutor) getAllCompactionResults() []*datapb.CompactionPlanResult {
|
|
results := make([]*datapb.CompactionPlanResult, 0)
|
|
// get executing results
|
|
c.executing.Range(func(planID int64, task compactor) bool {
|
|
results = append(results, &datapb.CompactionPlanResult{
|
|
State: commonpb.CompactionState_Executing,
|
|
PlanID: planID,
|
|
})
|
|
return true
|
|
})
|
|
|
|
// get completed results
|
|
c.completed.Range(func(planID int64, result *datapb.CompactionPlanResult) bool {
|
|
results = append(results, result)
|
|
return true
|
|
})
|
|
|
|
return results
|
|
}
|