milvus/internal/datanode/importv2/task_l0_import.go
yihao.dai ca758c36cc
enhance: Pre-allocate ids for compaction (#34187)
This PR removes the dependency of compaction on the ID allocator by
pre-allocating the logID and segmentID.

issue: https://github.com/milvus-io/milvus/issues/33957

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2024-07-17 13:23:42 +08:00

231 lines
6.6 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package importv2
import (
"context"
"fmt"
"io"
"math"
"time"
"github.com/cockroachdb/errors"
"github.com/samber/lo"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
"github.com/milvus-io/milvus/internal/allocator"
"github.com/milvus-io/milvus/internal/datanode/metacache"
"github.com/milvus-io/milvus/internal/datanode/syncmgr"
"github.com/milvus-io/milvus/internal/proto/datapb"
"github.com/milvus-io/milvus/internal/storage"
"github.com/milvus-io/milvus/internal/util/importutilv2/binlog"
"github.com/milvus-io/milvus/pkg/log"
"github.com/milvus-io/milvus/pkg/util/conc"
"github.com/milvus-io/milvus/pkg/util/merr"
"github.com/milvus-io/milvus/pkg/util/paramtable"
"github.com/milvus-io/milvus/pkg/util/typeutil"
)
type L0ImportTask struct {
*datapb.ImportTaskV2
ctx context.Context
cancel context.CancelFunc
segmentsInfo map[int64]*datapb.ImportSegmentInfo
req *datapb.ImportRequest
allocator allocator.Interface
manager TaskManager
syncMgr syncmgr.SyncManager
cm storage.ChunkManager
metaCaches map[string]metacache.MetaCache
}
func NewL0ImportTask(req *datapb.ImportRequest,
manager TaskManager,
syncMgr syncmgr.SyncManager,
cm storage.ChunkManager,
) Task {
ctx, cancel := context.WithCancel(context.Background())
// Setting end as math.MaxInt64 to incrementally allocate logID.
alloc := allocator.NewLocalAllocator(req.GetIDRange().GetBegin(), math.MaxInt64)
task := &L0ImportTask{
ImportTaskV2: &datapb.ImportTaskV2{
JobID: req.GetJobID(),
TaskID: req.GetTaskID(),
CollectionID: req.GetCollectionID(),
State: datapb.ImportTaskStateV2_Pending,
},
ctx: ctx,
cancel: cancel,
segmentsInfo: make(map[int64]*datapb.ImportSegmentInfo),
req: req,
allocator: alloc,
manager: manager,
syncMgr: syncMgr,
cm: cm,
}
task.metaCaches = NewMetaCache(req)
return task
}
func (t *L0ImportTask) GetType() TaskType {
return L0ImportTaskType
}
func (t *L0ImportTask) GetPartitionIDs() []int64 {
return t.req.GetPartitionIDs()
}
func (t *L0ImportTask) GetVchannels() []string {
return t.req.GetVchannels()
}
func (t *L0ImportTask) GetSchema() *schemapb.CollectionSchema {
return t.req.GetSchema()
}
func (t *L0ImportTask) Cancel() {
t.cancel()
}
func (t *L0ImportTask) GetSegmentsInfo() []*datapb.ImportSegmentInfo {
return lo.Values(t.segmentsInfo)
}
func (t *L0ImportTask) Clone() Task {
ctx, cancel := context.WithCancel(t.ctx)
infos := make(map[int64]*datapb.ImportSegmentInfo)
for id, info := range t.segmentsInfo {
infos[id] = typeutil.Clone(info)
}
return &L0ImportTask{
ImportTaskV2: typeutil.Clone(t.ImportTaskV2),
ctx: ctx,
cancel: cancel,
segmentsInfo: infos,
req: t.req,
metaCaches: t.metaCaches,
}
}
func (t *L0ImportTask) Execute() []*conc.Future[any] {
bufferSize := paramtable.Get().DataNodeCfg.ReadBufferSizeInMB.GetAsInt() * 1024 * 1024
log.Info("start to import l0", WrapLogFields(t,
zap.Int("bufferSize", bufferSize),
zap.Any("schema", t.GetSchema()))...)
t.manager.Update(t.GetTaskID(), UpdateState(datapb.ImportTaskStateV2_InProgress))
fn := func() (err error) {
defer func() {
if err != nil {
log.Warn("l0 import task execute failed", WrapLogFields(t, zap.Error(err))...)
t.manager.Update(t.GetTaskID(), UpdateState(datapb.ImportTaskStateV2_Failed), UpdateReason(err.Error()))
}
}()
if len(t.req.GetFiles()) != 1 {
err = merr.WrapErrImportFailed(
fmt.Sprintf("there should be one prefix for l0 import, but got %v", t.req.GetFiles()))
return
}
pkField, err := typeutil.GetPrimaryFieldSchema(t.GetSchema())
if err != nil {
return
}
reader, err := binlog.NewL0Reader(t.ctx, t.cm, pkField, t.req.GetFiles()[0], bufferSize)
if err != nil {
return
}
start := time.Now()
err = t.importL0(reader)
if err != nil {
return
}
log.Info("l0 import done", WrapLogFields(t,
zap.Strings("l0 prefix", t.req.GetFiles()[0].GetPaths()),
zap.Duration("dur", time.Since(start)))...)
return nil
}
f := GetExecPool().Submit(func() (any, error) {
err := fn()
return err, err
})
return []*conc.Future[any]{f}
}
func (t *L0ImportTask) importL0(reader binlog.L0Reader) error {
syncFutures := make([]*conc.Future[struct{}], 0)
syncTasks := make([]syncmgr.Task, 0)
for {
data, err := reader.Read()
if err != nil {
if errors.Is(err, io.EOF) {
break
}
return err
}
delData, err := HashDeleteData(t, data)
if err != nil {
return err
}
fs, sts, err := t.syncDelete(delData)
if err != nil {
return err
}
syncFutures = append(syncFutures, fs...)
syncTasks = append(syncTasks, sts...)
}
err := conc.AwaitAll(syncFutures...)
if err != nil {
return err
}
for _, syncTask := range syncTasks {
segmentInfo, err := NewImportSegmentInfo(syncTask, t.metaCaches)
if err != nil {
return err
}
t.manager.Update(t.GetTaskID(), UpdateSegmentInfo(segmentInfo))
log.Info("sync l0 data done", WrapLogFields(t, zap.Any("segmentInfo", segmentInfo))...)
}
return nil
}
func (t *L0ImportTask) syncDelete(delData []*storage.DeleteData) ([]*conc.Future[struct{}], []syncmgr.Task, error) {
log.Info("start to sync l0 delete data", WrapLogFields(t)...)
futures := make([]*conc.Future[struct{}], 0)
syncTasks := make([]syncmgr.Task, 0)
for channelIdx, data := range delData {
channel := t.GetVchannels()[channelIdx]
if data.RowCount == 0 {
continue
}
partitionID := t.GetPartitionIDs()[0]
segmentID := PickSegment(t.req.GetRequestSegments(), channel, partitionID)
syncTask, err := NewSyncTask(t.ctx, t.allocator, t.metaCaches, t.req.GetTs(),
segmentID, partitionID, t.GetCollectionID(), channel, nil, data)
if err != nil {
return nil, nil, err
}
future := t.syncMgr.SyncData(t.ctx, syncTask)
futures = append(futures, future)
syncTasks = append(syncTasks, syncTask)
}
return futures, syncTasks, nil
}