milvus/internal/querynode/flow_graph_delete_node_test.go
congqixia a8e6d5d47e
Fix delete operation scope to vchannel (#20866)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-11-29 15:15:15 +08:00

313 lines
9.3 KiB
Go

// Licensed to the LF AI & Data foundation under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package querynode
import (
"sync"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/milvus-io/milvus-proto/go-api/schemapb"
"github.com/milvus-io/milvus/internal/common"
"github.com/milvus-io/milvus/internal/mq/msgstream"
"github.com/milvus-io/milvus/internal/storage"
"github.com/milvus-io/milvus/internal/util/flowgraph"
)
func TestFlowGraphDeleteNode_delete(t *testing.T) {
t.Run("test delete", func(t *testing.T) {
historical, err := genSimpleReplica()
assert.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeSealed)
assert.NoError(t, err)
deleteData, err := genFlowGraphDeleteData()
assert.NoError(t, err)
wg := &sync.WaitGroup{}
wg.Add(1)
err = deleteNode.delete(deleteData, defaultSegmentID, wg)
assert.NoError(t, err)
})
t.Run("test segment delete error", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeSealed)
assert.NoError(t, err)
deleteData, err := genFlowGraphDeleteData()
assert.NoError(t, err)
wg := &sync.WaitGroup{}
wg.Add(1)
deleteData.deleteTimestamps[defaultSegmentID] = deleteData.deleteTimestamps[defaultSegmentID][:len(deleteData.deleteTimestamps)/2]
err = deleteNode.delete(deleteData, defaultSegmentID, wg)
assert.Error(t, err)
})
t.Run("test no target segment", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
wg := &sync.WaitGroup{}
wg.Add(1)
err = deleteNode.delete(nil, defaultSegmentID, wg)
assert.Error(t, err)
})
t.Run("test invalid segmentType", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeGrowing)
assert.NoError(t, err)
wg := &sync.WaitGroup{}
wg.Add(1)
err = deleteNode.delete(&deleteData{}, defaultSegmentID, wg)
assert.Error(t, err)
})
}
func TestFlowGraphDeleteNode_operate(t *testing.T) {
t.Run("test operate", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeSealed)
assert.NoError(t, err)
msgDeleteMsg := genDeleteMsg(defaultCollectionID, schemapb.DataType_Int64, defaultDelLength)
dMsg := deleteMsg{
deleteMessages: []*msgstream.DeleteMsg{
msgDeleteMsg,
},
}
msg := []flowgraph.Msg{&dMsg}
deleteNode.Operate(msg)
s, err := historical.getSegmentByID(defaultSegmentID, segmentTypeSealed)
assert.NoError(t, err)
pks := make([]primaryKey, defaultMsgLength)
for i := 0; i < defaultMsgLength; i++ {
pks[i] = newInt64PrimaryKey(int64(i))
}
// load bf
value := make([]int64, defaultMsgLength)
for i := 0; i < defaultMsgLength; i++ {
value[i] = int64(i)
}
data := &storage.Int64FieldData{
Data: value,
}
statsWriter := &storage.StatsWriter{}
err = statsWriter.GeneratePrimaryKeyStats(1, schemapb.DataType_Int64, data)
assert.NoError(t, err)
sr := &storage.StatsReader{}
sr.SetBuffer(statsWriter.GetBuffer())
stat, err := sr.GetPrimaryKeyStats()
assert.NoError(t, err)
s, err = historical.getSegmentByID(defaultSegmentID, segmentTypeSealed)
assert.NoError(t, err)
pkStat := &storage.PkStatistics{
PkFilter: stat.BF,
MinPK: stat.MinPk,
MaxPK: stat.MaxPk,
}
s.historyStats = append(s.historyStats, pkStat)
// another bf
for i := 0; i < defaultMsgLength; i++ {
value[i] = int64(i + defaultMsgLength)
}
err = statsWriter.GeneratePrimaryKeyStats(1, schemapb.DataType_Int64, data)
assert.NoError(t, err)
sr.SetBuffer(statsWriter.GetBuffer())
stat, err = sr.GetPrimaryKeyStats()
assert.NoError(t, err)
s, err = historical.getSegmentByID(defaultSegmentID, segmentTypeSealed)
assert.NoError(t, err)
pkStat = &storage.PkStatistics{
PkFilter: stat.BF,
MinPK: stat.MinPk,
MaxPK: stat.MaxPk,
}
s.historyStats = append(s.historyStats, pkStat)
assert.Nil(t, err)
for i := 0; i < defaultMsgLength*2; i++ {
assert.True(t, s.isPKExist(newInt64PrimaryKey(int64(i))))
}
assert.False(t, s.isPKExist(newInt64PrimaryKey(int64(defaultMsgLength*2+1))))
})
t.Run("test invalid partitionID", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeSealed)
assert.NoError(t, err)
msgDeleteMsg := genDeleteMsg(defaultCollectionID, schemapb.DataType_Int64, defaultDelLength)
msgDeleteMsg.PartitionID = common.InvalidPartitionID
assert.NoError(t, err)
dMsg := deleteMsg{
deleteMessages: []*msgstream.DeleteMsg{
msgDeleteMsg,
},
}
msg := []flowgraph.Msg{&dMsg}
deleteNode.Operate(msg)
})
t.Run("test collection partition not exist", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeSealed)
assert.NoError(t, err)
msgDeleteMsg := genDeleteMsg(defaultCollectionID, schemapb.DataType_Int64, defaultDelLength)
msgDeleteMsg.CollectionID = 9999
msgDeleteMsg.PartitionID = -1
assert.NoError(t, err)
dMsg := deleteMsg{
deleteMessages: []*msgstream.DeleteMsg{
msgDeleteMsg,
},
}
msg := []flowgraph.Msg{&dMsg}
assert.Panics(t, func() { deleteNode.Operate(msg) })
})
t.Run("test partition not exist", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeSealed)
assert.NoError(t, err)
msgDeleteMsg := genDeleteMsg(defaultCollectionID, schemapb.DataType_Int64, defaultDelLength)
msgDeleteMsg.PartitionID = 9999
assert.NoError(t, err)
dMsg := deleteMsg{
deleteMessages: []*msgstream.DeleteMsg{
msgDeleteMsg,
},
}
msg := []flowgraph.Msg{&dMsg}
assert.NotPanics(t, func() { deleteNode.Operate(msg) })
})
t.Run("test invalid input length", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
deleteNode, err := newDeleteNode(historical, defaultCollectionID, defaultDeltaChannel)
require.NoError(t, err)
err = historical.addSegment(defaultSegmentID,
defaultPartitionID,
defaultCollectionID,
defaultDMLChannel,
defaultSegmentVersion,
defaultSegmentStartPosition,
segmentTypeSealed)
assert.NoError(t, err)
msgDeleteMsg := genDeleteMsg(defaultCollectionID, schemapb.DataType_Int64, defaultDelLength)
dMsg := deleteMsg{
deleteMessages: []*msgstream.DeleteMsg{
msgDeleteMsg,
},
}
msg := []flowgraph.Msg{&dMsg, &dMsg}
deleteNode.Operate(msg)
})
t.Run("test bad deltaChannelName", func(t *testing.T) {
historical, err := genSimpleReplica()
require.NoError(t, err)
_, err = newDeleteNode(historical, defaultCollectionID, defaultDMLChannel)
assert.Error(t, err)
})
}