mirror of
https://gitee.com/milvus-io/milvus.git
synced 2024-12-01 19:39:21 +08:00
fc630bc1c8
Before this PR, DataNode considered auto-flush a valid flush complete. It's wrong. So I open this PR to correct this behaviour in DataNode. Now binlog paths from auto-flush will be buffered in replica, waiting until the manul flush to save into etcd all together. See also: #5220, #5268 A follow up job of #5271 Signed-off-by: yangxuan <xuan.yang@zilliz.com>
79 lines
2.1 KiB
Go
79 lines
2.1 KiB
Go
// Copyright (C) 2019-2020 Zilliz. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the License
|
|
// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
|
|
// or implied. See the License for the specific language governing permissions and limitations under the License.
|
|
|
|
package datanode
|
|
|
|
import (
|
|
"context"
|
|
"path"
|
|
"strconv"
|
|
|
|
"github.com/milvus-io/milvus/internal/types"
|
|
|
|
"github.com/milvus-io/milvus/internal/proto/commonpb"
|
|
"github.com/milvus-io/milvus/internal/proto/masterpb"
|
|
)
|
|
|
|
type allocatorInterface interface {
|
|
allocID() (UniqueID, error)
|
|
genKey(alloc bool, ids ...UniqueID) (key string, err error)
|
|
}
|
|
|
|
type allocator struct {
|
|
masterService types.MasterService
|
|
}
|
|
|
|
var _ allocatorInterface = &allocator{}
|
|
|
|
func newAllocator(s types.MasterService) *allocator {
|
|
return &allocator{
|
|
masterService: s,
|
|
}
|
|
}
|
|
|
|
func (alloc *allocator) allocID() (UniqueID, error) {
|
|
ctx := context.TODO()
|
|
resp, err := alloc.masterService.AllocID(ctx, &masterpb.AllocIDRequest{
|
|
Base: &commonpb.MsgBase{
|
|
MsgType: commonpb.MsgType_RequestID,
|
|
MsgID: 1, // GOOSE TODO
|
|
Timestamp: 0, // GOOSE TODO
|
|
SourceID: Params.NodeID,
|
|
},
|
|
Count: 1,
|
|
})
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
return resp.ID, nil
|
|
}
|
|
|
|
// genKey gives a valid key string for lists of UniqueIDs:
|
|
// if alloc is true, the returned keys will have a generated-unique ID at the end.
|
|
// if alloc is false, the returned keys will only consist of provided ids.
|
|
func (alloc *allocator) genKey(isalloc bool, ids ...UniqueID) (key string, err error) {
|
|
if isalloc {
|
|
idx, err := alloc.allocID()
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
ids = append(ids, idx)
|
|
}
|
|
|
|
idStr := make([]string, len(ids))
|
|
for _, id := range ids {
|
|
idStr = append(idStr, strconv.FormatInt(id, 10))
|
|
}
|
|
|
|
key = path.Join(idStr...)
|
|
return
|
|
}
|