fix(auth): user role not found (#2674)

packages/core/client/src/api-client/APIClient.ts

@@ -39,6 +39,20 @@ export class APIClient extends APIClientSDK {
     });
     super.interceptors();
     this.useNotificationMiddleware();
+    this.axios.interceptors.response.use(
+      (response) => {
+        return response;
+      },
+      (error) => {
+        const errs = error?.response?.data?.errors || [{ message: 'Server error' }];
+        // Hard code here temporarily
+        // TODO(yangqia): improve error code and message
+        if (errs.find((error: { code?: string }) => error.code === 'ROLE_NOT_FOUND_ERR')) {
+          this.auth.setRole(null);
+        }
+        throw error;
+      },
+    );
   }
 
   useNotificationMiddleware() {

packages/core/client/src/api-client/__tests__/APIClient.test.tsx

@@ -23,4 +23,40 @@ describe('APIClient', () => {
       expect(apiClient.axios).toBe(instance);
     });
   });
+
+  test('should reset role when role is not found', async () => {
+    const instance = axios.create();
+    instance.interceptors.response.use(
+      (response) => response,
+      (error) => {
+        error = {
+          response: {
+            data: {
+              errors: [
+                {
+                  code: 'ROLE_NOT_FOUND_ERR',
+                },
+              ],
+            },
+          },
+        };
+        throw error;
+      },
+    );
+    const apiClient = new APIClient(instance);
+    apiClient.app = {} as any;
+    apiClient.auth.setRole('not-found');
+    expect(apiClient.auth.role).toBe('not-found');
+    try {
+      await apiClient.request({
+        method: 'GET',
+        url: '/api/test',
+      });
+    } catch (err) {
+      console.log(err);
+      expect(err).toBeDefined();
+      expect(err.response.data.errors[0].code).toBe('ROLE_NOT_FOUND_ERR');
+    }
+    expect(apiClient.auth.role).toBeFalsy();
+  });
 });

packages/plugins/@nocobase/plugin-acl/src/server/__tests__/setCurrentRole.test.ts

@@ -67,7 +67,7 @@ describe('role', () => {
     const throwFn = jest.fn();
     ctx.throw = throwFn;
     await setCurrentRole(ctx, () => {});
-    expect(throwFn).lastCalledWith(401, 'User role not found');
+    expect(throwFn).lastCalledWith(401, { code: 'ROLE_NOT_FOUND_ERR', message: 'The user role does not exist.' });
     expect(ctx.state.currentRole).not.toBeDefined();
   });
 

packages/plugins/@nocobase/plugin-acl/src/server/__tests__/users.test.ts

@@ -94,7 +94,7 @@ describe('actions', () => {
     const rolesCheckResponse2 = (await loggedAgent.set('Accept', 'application/json').get('/roles:check')) as any;
 
     expect(rolesCheckResponse2.status).toEqual(401);
-    expect(rolesCheckResponse2.body.errors[0].message).toEqual('User role not found');
+    expect(rolesCheckResponse2.body.errors[0].code).toEqual('ROLE_NOT_FOUND_ERR');
   });
 
   it('should destroy through table record when destroy role', async () => {

packages/plugins/@nocobase/plugin-acl/src/server/middlewares/setCurrentRole.ts

@@ -28,7 +28,7 @@ export async function setCurrentRole(ctx: Context, next) {
   }
 
   if (!ctx.state.currentRole) {
-    return ctx.throw(401, 'User role not found');
+    return ctx.throw(401, { code: 'ROLE_NOT_FOUND_ERR', message: 'The user role does not exist.' });
   }
 
   await next();