test/vue
1
0
Fork 0
mirror of https://gitee.com/vuejs/vue.git synced 2024-12-04 13:07:40 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

should invoke destroy hook for replaced root nodes too

Browse Source
This commit is contained in:
Evan You 2016-05-28 21:05:53 -04:00
parent 5aeb7f5eef
commit 99a96d3c37
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/vdom/patch.js
View File

@ -383,6 +383,8 @@ export function createPatchFunction (backend) {
if (parent !== null) {
nodeOps.insertBefore(parent, vnode.elm, nodeOps.nextSibling(elm))
removeVnodes(parent, [oldVnode], 0, 0)
} else if (isDef(oldVnode.tag)) {
invokeDestroyHook(oldVnode)
}
}
}

6
test/unit/modules/vdom/patch/hooks.spec.js
View File

@ -244,9 +244,10 @@ describe('hooks', () => {
])
const vnode2 = new VNode('div')
patch1(vnode0, vnode1)
expect(destroyed).toBe(1) // should invoke for replaced root nodes too
patch1(vnode1, vnode2)
expect(created).toBe(5)
expect(destroyed).toBe(4)
expect(destroyed).toBe(5)
})
it('should not invoke `create` and `remove` module hook for text nodes', () => {
@ -293,9 +294,10 @@ describe('hooks', () => {
])
const vnode2 = new VNode('div')
patch1(vnode0, vnode1)
expect(destroyed).toBe(1) // should invoke for replaced root nodes too
patch1(vnode1, vnode2)
expect(created).toBe(5)
expect(destroyed).toBe(4)
expect(destroyed).toBe(5)
})
it('should call `create` listener before inserted into parent but after children', () => {